xfs_scrub: bitmap iteration functions must retur

bitmap_iterate doesn't generate its own errors, so don't invert the sign
of the errors returned from retry_deferred_inode_range.  This keeps them
all positive, which is something that Codex is good at noticing and I'm
not. :P

Cc: linux-xfs@vger.kernel.org # v6.10.0
Fixes: 5a30504f0c60e1 ("xfs_scrub: defer phase5 file scans if dirloop fails")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Andrey Albershteyn <aalbersh@kernel.org>

diff --git a/scrub/phase5.c b/scrub/phase5.c
index 52bbbca4b9f06a5d91e0468fd68cab15d9d9f318..329d208d882ef13cb3a9c98980b69336cf1c8474 100644 (file)
--- a/scrub/phase5.c
+++ b/scrub/phase5.c
@@ -527,7 +527,7 @@ retry_deferred_inodes(
                ncs->new_deferred = NULL;
                ncs->fixed_something = false;
 
-               error = -bitmap_iterate(ncs->cur_deferred,
+               error = bitmap_iterate(ncs->cur_deferred,
                                retry_deferred_inode_range, ncs);
                if (error)
                        return error;
@@ -546,7 +546,7 @@ retry_deferred_inodes(
        ncs->new_deferred = NULL;
        ncs->last_call = true;
 
-       error = -bitmap_iterate(ncs->cur_deferred,
+       error = bitmap_iterate(ncs->cur_deferred,
                        retry_deferred_inode_range, ncs);
        if (error)
                return error;