]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
pybind/mgr/dashboard: refactor overlong statement
authorKefu Chai <kchai@redhat.com>
Tue, 20 Oct 2020 10:33:29 +0000 (18:33 +0800)
committerKefu Chai <kchai@redhat.com>
Tue, 20 Oct 2020 11:13:12 +0000 (19:13 +0800)
to silence lint warning like:

services/tcmu_service.py:64:39: E126 continuation line over-indented for hanging indent':'./services/tcmu_service.py:64:39: E126 continuation line over-indented for hanging indent'}
2: 1     E126 continuation line over-indented for hanging indent

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/pybind/mgr/dashboard/services/tcmu_service.py

index 3ded28f9d2d685cc57d3c6d5b062e16950594ff6..2cc8cffebed6a5fefe38d6af94d7823684b8c7b2 100644 (file)
@@ -59,9 +59,13 @@ class TcmuService(object):
                     pool=metadata['pool_name'],
                     name=metadata['image_name'])
                 perf_key = "{}lock_acquired_time".format(perf_key_prefix)
-                lock_acquired_time = (mgr.get_counter(
-                    'tcmu-runner', service_id, perf_key)[perf_key]
-                                      or [[0, 0]])[-1][1] / 1000000000
+                perf_value = mgr.get_counter('tcmu-runner',
+                                             service_id,
+                                             perf_key)[perf_key]
+                if perf_value:
+                    lock_acquired_time = perf_value[-1][1] / 1000000000
+                else:
+                    lock_acquired_time = 0
                 if lock_acquired_time > image.get('optimized_since', 0):
                     image['optimized_daemon'] = hostname
                     image['optimized_since'] = lock_acquired_time