]> git.apps.os.sepia.ceph.com Git - ceph-ansible.git/commitdiff
osds: do not set docker_exec_cmd fact
authorGuillaume Abrioux <gabrioux@redhat.com>
Wed, 30 May 2018 10:09:16 +0000 (12:09 +0200)
committerGuillaume Abrioux <gabrioux@redhat.com>
Wed, 30 May 2018 14:17:29 +0000 (16:17 +0200)
in `ceph-osd` there is no need to set `docker_exec_cmd` since the only
place where this fact is used is in `openstack_config.yml` which
delegate all docker command to a monitor node. It means we need the
`docker_exec_cmd` fact that has been set referring to `ceph-mon-*`
containers, this fact is already set earlier in `ceph-defaults`.

By the way, when collocating an OSD with a MON it fails because the container
`ceph-osd-{{ ansible_hostname }}` doesn't exist.

Removing this task will allow to collocate an OSD with a MON.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1584179
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
roles/ceph-osd/tasks/main.yml

index baa65a19bcede17d9c7783f35da7a33a6de6ff94..a0889b951238f330acdf531322da2aa377a7da00 100644 (file)
@@ -1,10 +1,4 @@
 ---
-- name: set_fact docker_exec_cmd
-  set_fact:
-    docker_exec_cmd: "docker exec ceph-osd-{{ ansible_hostname }}"
-  when:
-    - containerized_deployment
-
 - name: include system_tuning.yml
   include: system_tuning.yml
   # Hard code this so we will skip the entire file instead of individual tasks (Default isn't Consistent)