]> git-server-git.apps.pok.os.sepia.ceph.com Git - xfsprogs-dev.git/commitdiff
xfs_scrub: fix inverted return value from ptvar_get
authorDarrick J. Wong <djwong@kernel.org>
Thu, 4 Jun 2026 06:09:00 +0000 (23:09 -0700)
committerAndrey Albershteyn <aalbersh@kernel.org>
Thu, 11 Jun 2026 10:26:04 +0000 (12:26 +0200)
Codex noticed that this callsite to ptvar_get got the sign of the error
code backwards, unlike all the other callers.  Fix that.

Cc: linux-xfs@vger.kernel.org # v6.10.0
Fixes: 4f4d99615d2377 ("xfs_scrub: improve thread scheduling repair items during phase 4")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Andrey Albershteyn <aalbersh@kernel.org>
scrub/phase3.c

index 046a42c1da8bebcfd82d8994ca33002b2d56579b..93900fb813e489449c9eeaa07708a5e115272ed0 100644 (file)
@@ -68,9 +68,9 @@ defer_inode_repair(
 
        alist = ptvar_get(ictx->repair_ptlists, &ret);
        if (ret) {
-               str_liberror(ictx->ctx, ret,
+               str_liberror(ictx->ctx, -ret,
  _("getting per-thread inode repair list"));
-               return ret;
+               return -ret;
        }
 
        action_list_add(alist, aitem);