]> git.apps.os.sepia.ceph.com Git - teuthology.git/commitdiff
task.tests: Use job_status module
authorZack Cerza <zack@redhat.com>
Thu, 3 Mar 2022 21:08:57 +0000 (14:08 -0700)
committerZack Cerza <zack@redhat.com>
Wed, 16 Mar 2022 22:51:16 +0000 (16:51 -0600)
Previously this task had an embarrassing "status=fail, success=true"
bug.

Signed-off-by: Zack Cerza <zack@redhat.com>
teuthology/task/tests/__init__.py

index a510a4a1cc8e83d5d15d776647d1d9544a755926..088e84483e0883d9b64300c1bc7463147101c60b 100644 (file)
@@ -14,6 +14,8 @@ An example::
 import logging
 import pytest
 
+from teuthology.job_status import set_status
+
 
 log = logging.getLogger(__name__)
 
@@ -92,12 +94,12 @@ def task(ctx, config):
             plugins=[TeuthologyContextPlugin(ctx, config)]
         )
     except Exception:
-        log.exception("Saw failure running pytest")
-        ctx.summary["status"] = "dead"
+        log.exception("Saw non-test failure!")
+        set_status(ctx.summary, "dead")
     else:
         if status == 0:
             log.info("OK. All tests passed!")
-            ctx.summary["status"] = "pass"
+            set_status(ctx.summary, "pass")
         else:
             log.error("FAIL. Saw test failures...")
-            ctx.summary["status"] = "fail"
+            set_status(ctx.summary, "fail")