]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commitdiff
xfs/019: reduce _fail calls in test
authorDarrick J. Wong <djwong@kernel.org>
Thu, 20 Feb 2025 21:47:04 +0000 (13:47 -0800)
committerZorro Lang <zlang@kernel.org>
Thu, 6 Mar 2025 13:25:55 +0000 (21:25 +0800)
Replace some _fail calls in this test with softer variants: First,
_scratch_mount does _try_scratch_mount || _fail so it can go away.

Replace the rest of them with echoes because that's sufficient to fail
the test without omitting further check.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Zorro Lang <zlang@kernel.org>
tests/xfs/019

index fdd965aa908f2baa01c22f1e1a7ce4ac04a69b18..b30116560c7c4044583e3847a7c16984f4deabf1 100755 (executable)
@@ -106,22 +106,21 @@ _verify_fs()
 
        echo "*** mount FS"
        _full " mount"
-       _try_scratch_mount >>$seqfull 2>&1 \
-               || _fail "mount failed"
+       _scratch_mount >>$seqfull 2>&1
 
        echo "*** verify FS"
        (cd $SCRATCH_MNT ; find . | LC_COLLATE=POSIX sort \
                | grep -v ".use_space" \
                | xargs $here/src/lstat64 | _filter_stat)
        diff -q $SCRATCH_MNT/bigfile $tempfile.2 \
-               || _fail "bigfile corrupted"
+               || echo "bigfile corrupted"
        diff -q $SCRATCH_MNT/symlink $tempfile.2 \
-               || _fail "symlink broken"
+               || echo "symlink broken"
 
        echo "*** unmount FS"
        _full "umount"
        _scratch_unmount >>$seqfull 2>&1 \
-               || _fail "umount failed"
+               || echo "umount failed"
 }
 
 #_verify_fs 1