]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mgr/cephadm: SNMP: don't write urls manually
authorSebastian Wagner <sewagner@redhat.com>
Thu, 16 Dec 2021 16:57:50 +0000 (17:57 +0100)
committerSebastian Wagner <sewagner@redhat.com>
Wed, 5 Jan 2022 09:23:05 +0000 (10:23 +0100)
this just broken for non-trivial urls. Don't be a bad example

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
src/pybind/mgr/cephadm/services/monitoring.py

index c252462c212eb04ea0e95755fabf00d26448517c..d67d3057bb80765d3ac74fe9c58b57781b2c4e41 100644 (file)
@@ -158,7 +158,9 @@ class AlertmanagerService(CephadmService):
             assert dd.ports
             addr = dd.ip if dd.ip else self._inventory_get_addr(dd.hostname)
             deps.append(dd.name())
-            snmp_gateway_urls.append(f"http://{addr}:{dd.ports[0]}/alerts")
+
+            snmp_gateway_urls.append(build_url(scheme='http', host=addr,
+                                     port=dd.ports[0], path='/alerts'))
 
         context = {
             'dashboard_urls': dashboard_urls,