Better --check compatibility for ceph-rbd-mirror role

Carefully chosen "always_run: true" parameters for read-only tasks that
register variables. This enables --check runs (at least on deployed
clusters).

diff --git a/roles/ceph-rbd-mirror/tasks/docker/checks.yml b/roles/ceph-rbd-mirror/tasks/docker/checks.yml
index 09cb57b577440d923c8b11179af952b01e8cca31..968fc038cf215e407ccfce9386f44280021686b9 100644 (file)
--- a/roles/ceph-rbd-mirror/tasks/docker/checks.yml
+++ b/roles/ceph-rbd-mirror/tasks/docker/checks.yml
@@ -16,6 +16,7 @@
   with_items: "{{ ceph_config_keys }}"
   changed_when: false
   failed_when: false
+  always_run: true
   register: statleftover
 
 - name: fail if we find existing cluster files

diff --git a/roles/ceph-rbd-mirror/tasks/docker/dirs_permissions.yml b/roles/ceph-rbd-mirror/tasks/docker/dirs_permissions.yml
index 3a85017f2c9613ec65d3adcd9fce71bfeba7b3dc..dedc4948dfd0a72c42e67f85481df42622be72c7 100644 (file)
--- a/roles/ceph-rbd-mirror/tasks/docker/dirs_permissions.yml
+++ b/roles/ceph-rbd-mirror/tasks/docker/dirs_permissions.yml
@@ -5,6 +5,7 @@
   shell: docker inspect "docker.io/{{ ceph_rbd_mirror_docker_username }}/{{ ceph_rbd_mirror_docker_imagename }}:{{ ceph_rbd_mirror_docker_image_tag }}" | awk -F '=' '/CEPH_VERSION/ { gsub ("\",", "", $2); print $2 }' | uniq
   changed_when: false
   failed_when: false
+  always_run: true
   run_once: true
   register: ceph_version
 

diff --git a/roles/ceph-rbd-mirror/tasks/docker/fetch_configs.yml b/roles/ceph-rbd-mirror/tasks/docker/fetch_configs.yml
index b2d3b6c82ee9ceafdf768835b7858d04343a7f73..2c4c4fa11bfde778e4de5c302e758c4355238aac 100644 (file)
--- a/roles/ceph-rbd-mirror/tasks/docker/fetch_configs.yml
+++ b/roles/ceph-rbd-mirror/tasks/docker/fetch_configs.yml
@@ -13,6 +13,7 @@
   changed_when: false
   become: false
   failed_when: false
+  always_run: true
   register: statconfig
 
 - name: try to fetch ceph config and keys

diff --git a/roles/ceph-rbd-mirror/tasks/docker/main.yml b/roles/ceph-rbd-mirror/tasks/docker/main.yml
index 87aace0be4278797408810b418aec5c0ff499a39..ea707311885f3bb4951198ff28e19de1ea2f15c1 100644 (file)
--- a/roles/ceph-rbd-mirror/tasks/docker/main.yml
+++ b/roles/ceph-rbd-mirror/tasks/docker/main.yml
@@ -4,9 +4,11 @@
   register: ceph_health
   changed_when: false
   failed_when: false
+  always_run: true
 
 - name: check if it is Atomic host
   stat: path=/run/ostree-booted
+  always_run: true
   register: stat_ostree
 
 - name: set fact for using Atomic host

diff --git a/roles/ceph-rbd-mirror/tasks/docker/selinux.yml b/roles/ceph-rbd-mirror/tasks/docker/selinux.yml
index ce8b3054f76ef2c73de9d87d1fa0ac5ca82e13d8..59fd6667ad79f0aac44049677357ccac6cf86a6c 100644 (file)
--- a/roles/ceph-rbd-mirror/tasks/docker/selinux.yml
+++ b/roles/ceph-rbd-mirror/tasks/docker/selinux.yml
@@ -3,6 +3,7 @@
   command: getenforce
   register: sestatus
   changed_when: false
+  always_run: true
 
 - name: set selinux permissions
   shell: chcon -Rt svirt_sandbox_file_t {{ item }}