rgw: Add coverity annotations for uncaught exceptions in standalone binaries

Signed-off-by: Vedansh Bhartia <vedanshbhartia@gmail.com>

diff --git a/src/rgw/driver/dbstore/dbstore_main.cc b/src/rgw/driver/dbstore/dbstore_main.cc
index 4fff38ced279936367a23a94913bc33d05cd024d..46d4106ca436afd328018aed07c4f39b3c3c6926 100644 (file)
--- a/src/rgw/driver/dbstore/dbstore_main.cc
+++ b/src/rgw/driver/dbstore/dbstore_main.cc
@@ -119,6 +119,9 @@ void* process(void *arg)
   return 0;
 }
 
+// This has an uncaught exception. Even if the exception is caught, the program
+// would need to be terminated, so the warning is simply suppressed.
+// coverity[root_function:SUPPRESS]
 int main(int argc, char *argv[])
 {
   string tenant = "Redhat";

diff --git a/src/rgw/rgw_admin.cc b/src/rgw/rgw_admin.cc
index a4e17b8895ae80619947fc2ddb239ec1c8c76b82..01a07f2c2deaa298ffedea17281b077e1de18019 100644 (file)
--- a/src/rgw/rgw_admin.cc
+++ b/src/rgw/rgw_admin.cc
@@ -3305,6 +3305,9 @@ void init_realm_param(CephContext *cct, string& var, std::optional<string>& opt_
   }
 }
 
+// This has an uncaught exception. Even if the exception is caught, the program
+// would need to be terminated, so the warning is simply suppressed.
+// coverity[root_function:SUPPRESS]
 int main(int argc, const char **argv)
 {
   auto args = argv_to_vec(argc, argv);

diff --git a/src/rgw/rgw_es_main.cc b/src/rgw/rgw_es_main.cc
index 6cfbc9352926c944ddde13367ddda318309dfceb..d84f9ecadd58a7b7a888957a7903d8e9864a2623 100644 (file)
--- a/src/rgw/rgw_es_main.cc
+++ b/src/rgw/rgw_es_main.cc
@@ -14,6 +14,9 @@
 
 using namespace std;
 
+// This has an uncaught exception. Even if the exception is caught, the program
+// would need to be terminated, so the warning is simply suppressed.
+// coverity[root_function:SUPPRESS]
 int main(int argc, char *argv[])
 {
   auto args = argv_to_vec(argc, argv);

diff --git a/src/rgw/rgw_jsonparser.cc b/src/rgw/rgw_jsonparser.cc
index 6541630b286d33372f22196b79e6e1b9648c663b..a6c99c6398900b7e5fe9c68e1a567f5813c389ae 100644 (file)
--- a/src/rgw/rgw_jsonparser.cc
+++ b/src/rgw/rgw_jsonparser.cc
@@ -56,7 +56,9 @@ struct UserInfo {
   }
 };
 
-
+// This has an uncaught exception. Even if the exception is caught, the program
+// would need to be terminated, so the warning is simply suppressed.
+// coverity[root_function:SUPPRESS]
 int main(int argc, char **argv) {
   JSONParser parser;
 

diff --git a/src/rgw/rgw_main.cc b/src/rgw/rgw_main.cc
index 27b02f841951db1941bdd61143b8478f75f764ef..4d31db8072f5ff6082bd7b30b2d8c971c7bf6288 100644 (file)
--- a/src/rgw/rgw_main.cc
+++ b/src/rgw/rgw_main.cc
@@ -57,7 +57,11 @@ static int usage()
 
 /*
  * start up the RADOS connection and then handle HTTP messages as they come in
+ *
+ * This has an uncaught exception. Even if the exception is caught, the program
+ * would need to be terminated, so the warning is simply suppressed.
  */
+// coverity[root_function:SUPPRESS]
 int main(int argc, char *argv[])
 { 
   int r{0};

diff --git a/src/rgw/rgw_multiparser.cc b/src/rgw/rgw_multiparser.cc
index a8778abd9a08b04c7e40de90e44f90ffab685229..c7a37213c4db8e80a1321f4c88f31cecd9f8d370 100644 (file)
--- a/src/rgw/rgw_multiparser.cc
+++ b/src/rgw/rgw_multiparser.cc
@@ -14,6 +14,10 @@
 
 using namespace std;
 
+
+// This has an uncaught exception. Even if the exception is caught, the program
+// would need to be terminated, so the warning is simply suppressed.
+// coverity[root_function:SUPPRESS]
 int main(int argc, char **argv) {
   RGWMultiXMLParser parser;
 

diff --git a/src/rgw/rgw_object_expirer.cc b/src/rgw/rgw_object_expirer.cc
index 7a49fc8d161efda797579d000a8962d5996782b0..0470b1a6e6fc28bf394054c40087913e4fb8b9df 100644 (file)
--- a/src/rgw/rgw_object_expirer.cc
+++ b/src/rgw/rgw_object_expirer.cc
@@ -51,6 +51,9 @@ static void usage()
   generic_server_usage();
 }
 
+// This has an uncaught exception. Even if the exception is caught, the program
+// would need to be terminated, so the warning is simply suppressed.
+// coverity[root_function:SUPPRESS]
 int main(const int argc, const char **argv)
 {
   auto args = argv_to_vec(argc, argv);

diff --git a/src/rgw/rgw_polparser.cc b/src/rgw/rgw_polparser.cc
index eca5066b3ce3cafe412bbe2ee5014ff600189f9c..3991181809ee254ef88acfdcbd7e9d3d44079971 100644 (file)
--- a/src/rgw/rgw_polparser.cc
+++ b/src/rgw/rgw_polparser.cc
@@ -50,6 +50,9 @@ void usage(std::string_view cmdname)
            << std::endl;
 }
 
+// This has an uncaught exception. Even if the exception is caught, the program
+// would need to be terminated, so the warning is simply suppressed.
+// coverity[root_function:SUPPRESS]
 int main(int argc, const char** argv)
 {
   std::string_view cmdname = argv[0];

diff --git a/src/rgw/rgw_token.cc b/src/rgw/rgw_token.cc
index 999d46e0e229ff4766edb1e895b3e76957d6e0b7..8ffac69c83136645047957e080466c843b3205bc 100644 (file)
--- a/src/rgw/rgw_token.cc
+++ b/src/rgw/rgw_token.cc
@@ -60,6 +60,9 @@ void usage()
   generic_client_usage();
 }
 
+// This has an uncaught exception. Even if the exception is caught, the program
+// would need to be terminated, so the warning is simply suppressed.
+// coverity[root_function:SUPPRESS]
 int main(int argc, char **argv)
 {
   auto args = argv_to_vec(argc, argv);