]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mgr/balancer: don't use 'foo' tags on commands
authorJohn Spray <john.spray@redhat.com>
Wed, 13 Dec 2017 13:08:46 +0000 (13:08 +0000)
committerJohn Spray <john.spray@redhat.com>
Wed, 13 Dec 2017 13:09:56 +0000 (13:09 +0000)
This looks weird in logs when code elsewhere logs
that it didn't handle a command with tag 'foo'

Fixes: http://tracker.ceph.com/issues/22361
Signed-off-by: John Spray <john.spray@redhat.com>
src/pybind/mgr/balancer/module.py

index 8fddaa6866656344e9809c0308565e115c8d9db5..1870dc012eecee8392a4e227f19c230c2c385658 100644 (file)
@@ -877,13 +877,13 @@ class Module(MgrModule):
         for osd, weight in plan.compat_ws.iteritems():
             self.log.info('ceph osd crush weight-set reweight-compat osd.%d %f',
                           osd, weight)
-            result = CommandResult('foo')
+            result = CommandResult('')
             self.send_command(result, 'mon', '', json.dumps({
                 'prefix': 'osd crush weight-set reweight-compat',
                 'format': 'json',
                 'item': 'osd.%d' % osd,
                 'weight': [weight],
-            }), 'foo')
+            }), '')
             commands.append(result)
 
         # new_weight
@@ -892,12 +892,12 @@ class Module(MgrModule):
             reweightn[str(osd)] = str(int(weight * float(0x10000)))
         if len(reweightn):
             self.log.info('ceph osd reweightn %s', reweightn)
-            result = CommandResult('foo')
+            result = CommandResult('')
             self.send_command(result, 'mon', '', json.dumps({
                 'prefix': 'osd reweightn',
                 'format': 'json',
                 'weights': json.dumps(reweightn),
-            }), 'foo')
+            }), '')
             commands.append(result)
 
         # upmap