]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commitdiff
check: Make -g and -x option meet description in manual
authorZhao Lei <zhaolei@cn.fujitsu.com>
Tue, 4 Aug 2015 04:10:49 +0000 (14:10 +1000)
committerDave Chinner <david@fromorbit.com>
Tue, 4 Aug 2015 04:10:49 +0000 (14:10 +1000)
In manual:
 # ./check --help
 ...
 -g group[,group...] include tests from these groups
 -x group[,group...] exclude tests from these groups
 ...

Above format is not supported, because ',' is not parsed in code.
This patch fixed it.

Before patch:
 # ./check -g scrub,replace
 Group "scrub,replace" is empty or not defined?

After patch:
 # ./check -g scrub,replace
 FSTYP         -- btrfs
 PLATFORM      -- Linux/x86_64 kerneldev 4.2.0-rc2_HEAD_c65b99f046843d2455aa231747b5a07a999a9f3d_+
 MKFS_OPTIONS  -- /dev/vdd
 MOUNT_OPTIONS -- /dev/vdd /var/ltf/tester/scratch_mnt
 ...(right result)...

Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
check

diff --git a/check b/check
index 866b7066e17aa77934245275012980c6f1d6a51f..4307a330224b314fb2404eeff35d9aa13aae0082 100755 (executable)
--- a/check
+++ b/check
@@ -209,11 +209,11 @@ while [ $# -gt 0 ]; do
        -tmpfs) FSTYP=tmpfs ;;
 
        -g)     group=$2 ; shift ;
-               GROUP_LIST="$GROUP_LIST $group"
+               GROUP_LIST="$GROUP_LIST ${group//,/ }"
                ;;
 
        -x)     xgroup=$2 ; shift ;
-               XGROUP_LIST="$XGROUP_LIST $xgroup"
+               XGROUP_LIST="$XGROUP_LIST ${xgroup//,/ }"
                ;;
 
        -X)     xfile=$2; shift ;