Better --check compatibility for ceph-nfs role

Carefully chosen "always_run: true" parameters for read-only tasks that
register variables. This enables --check runs (at least on deployed
clusters).

diff --git a/roles/ceph-nfs/tasks/docker/checks.yml b/roles/ceph-nfs/tasks/docker/checks.yml
index ec58106f6a83fdf055924cd1c43438bceac1e77e..e6d00d031d518691ce652bd311d26d26b94b4dd1 100644 (file)
--- a/roles/ceph-nfs/tasks/docker/checks.yml
+++ b/roles/ceph-nfs/tasks/docker/checks.yml
@@ -14,6 +14,7 @@
   with_items: "{{ ceph_config_keys }}"
   changed_when: false
   failed_when: false
+  always_run: true
   register: statleftover
 
 - name: fail if we find existing cluster files

diff --git a/roles/ceph-nfs/tasks/docker/copy_configs.yml b/roles/ceph-nfs/tasks/docker/copy_configs.yml
index 920c7623d16fbf0ef273ecbb4350d4143a574d0d..8101f2f953cb3413705c06a7216e6f552cffb554 100644 (file)
--- a/roles/ceph-nfs/tasks/docker/copy_configs.yml
+++ b/roles/ceph-nfs/tasks/docker/copy_configs.yml
@@ -12,6 +12,7 @@
   changed_when: false
   become: false
   failed_when: false
+  always_run: true
   register: statconfig
 
 - name: try to fetch config and keys

diff --git a/roles/ceph-nfs/tasks/docker/create_configs.yml b/roles/ceph-nfs/tasks/docker/create_configs.yml
index 8053d4f5f30dd9374060d87233eb00a00f0edcaf..edb3dcdbbb63df1b13022e3ee7ea313c55a63492 100644 (file)
--- a/roles/ceph-nfs/tasks/docker/create_configs.yml
+++ b/roles/ceph-nfs/tasks/docker/create_configs.yml
@@ -21,6 +21,7 @@
 
 - name: get user create output
   command: docker logs ceph-{{ ansible_hostname }}-rgw-user
+  always_run: true
   register: rgwuser
 
 - name: generate ganesha configuration file

diff --git a/roles/ceph-nfs/tasks/docker/dirs_permissions.yml b/roles/ceph-nfs/tasks/docker/dirs_permissions.yml
index b83f36b8c28d5603d79114c0e92ed87f4a518aca..e4456bd8ee433d7cec3ece4ad105d91dcf667a46 100644 (file)
--- a/roles/ceph-nfs/tasks/docker/dirs_permissions.yml
+++ b/roles/ceph-nfs/tasks/docker/dirs_permissions.yml
@@ -6,6 +6,7 @@
   changed_when: false
   failed_when: false
   run_once: true
+  always_run: true
   register: ceph_version
 
 - set_fact:

diff --git a/roles/ceph-nfs/tasks/docker/fetch_configs.yml b/roles/ceph-nfs/tasks/docker/fetch_configs.yml
index d94b1dad63ff913163f71fda43e899eb071a94d8..549ff8ca8001b7740f59be103eef6a1e9a56241f 100644 (file)
--- a/roles/ceph-nfs/tasks/docker/fetch_configs.yml
+++ b/roles/ceph-nfs/tasks/docker/fetch_configs.yml
@@ -10,6 +10,7 @@
   changed_when: false
   become: false
   failed_when: false
+  always_run: true
   register: statconfig
 
 - name: try to fetch config and keys

diff --git a/roles/ceph-nfs/tasks/docker/main.yml b/roles/ceph-nfs/tasks/docker/main.yml
index fc2024381067fab33b659a6c36c18becd53f9fe8..a54fb12b1331ca4b1099118ecf29885161acba0b 100644 (file)
--- a/roles/ceph-nfs/tasks/docker/main.yml
+++ b/roles/ceph-nfs/tasks/docker/main.yml
@@ -4,10 +4,12 @@
   register: ceph_health
   changed_when: false
   failed_when: false
+  always_run: true
 
 - name: check if it is Atomic host
   stat: path=/run/ostree-booted
   register: stat_ostree
+  always_run: true
 
 - name: set fact for using Atomic host
   set_fact:

diff --git a/roles/ceph-nfs/tasks/docker/selinux.yml b/roles/ceph-nfs/tasks/docker/selinux.yml
index 6d8395832e0f2ed9dd474c5ef0e8dda82f4181a1..be983910bca5c969b9690afec5334d2ebef632c9 100644 (file)
--- a/roles/ceph-nfs/tasks/docker/selinux.yml
+++ b/roles/ceph-nfs/tasks/docker/selinux.yml
@@ -3,6 +3,7 @@
   command: getenforce
   register: sestatus
   changed_when: false
+  always_run: true
 
 - name: set selinux permissions
   shell: chcon -Rt svirt_sandbox_file_t {{ item }}