tests: clean nfs_ganesha variables

- clean some leftover.
- move nfs_ganesha_[stable|dev] in group_vars so dev_setup.yml can modify them.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

diff --git a/tests/functional/all_daemons/container/hosts-ubuntu b/tests/functional/all_daemons/container/hosts-ubuntu
index 001a3981dda39732afbd87b7de160080a5ef20fb..d0adf6308ed057a8533d636cdfe9ae0f9721a3dd 100644 (file)
--- a/tests/functional/all_daemons/container/hosts-ubuntu
+++ b/tests/functional/all_daemons/container/hosts-ubuntu
@@ -25,11 +25,3 @@ client1
 
 [rbdmirrors]
 rbd-mirror0
-
-[all:vars]
-debian_ceph_packages=['ceph', 'ceph-common', 'ceph-fuse']
-nfs_ganesha_stable=True
-nfs_ganesha_stable_branch="V2.7-stable"
-nfs_ganesha_stable_deb_repo="{{ ceph_mirror }}/nfs-ganesha/deb-{{ nfs_ganesha_stable_branch }}/{{ ceph_stable_release }}"
-nfs_ganesha_dev=False
-nfs_ganesha_flavor="ceph_master"

diff --git a/tests/functional/all_daemons/group_vars/nfss b/tests/functional/all_daemons/group_vars/nfss
index 2d2f83bb67e38c8cc9879901e2d454533b457d4d..d4f560c144ba8d0c715486960549f39c37eecea0 100644 (file)
--- a/tests/functional/all_daemons/group_vars/nfss
+++ b/tests/functional/all_daemons/group_vars/nfss
@@ -5,3 +5,7 @@ ganesha_conf_overrides: |
     CACHEINODE {
             Entries_HWMark = 100000;
     }
+nfs_ganesha_stable: true
+nfs_ganesha_dev: false
+nfs_ganesha_flavor: "ceph_master"
+nfs_ganesha_stable_branch: "V2.7-stable"

diff --git a/tests/functional/all_daemons/hosts b/tests/functional/all_daemons/hosts
index 20c0d459922fe0decb75d6a4204f09a6f30dc079..9345ec8832e2afc043ea556393b1c17536cd7b7d 100644 (file)
--- a/tests/functional/all_daemons/hosts
+++ b/tests/functional/all_daemons/hosts
@@ -28,9 +28,3 @@ rbd-mirror0
 
 [iscsigws]
 iscsi-gw0 ceph_repository="dev"
-
-[all:vars]
-nfs_ganesha_stable=True
-nfs_ganesha_dev=False
-nfs_ganesha_stable_branch="V2.7-stable"
-nfs_ganesha_flavor="ceph_master"

diff --git a/tests/functional/all_daemons/hosts-ubuntu b/tests/functional/all_daemons/hosts-ubuntu
index 073cde5f668710cc7bbf3d1e88a04e6e4be5bc9d..0c2eed779d03705687f556b0145a4b74be1221b8 100644 (file)
--- a/tests/functional/all_daemons/hosts-ubuntu
+++ b/tests/functional/all_daemons/hosts-ubuntu
@@ -28,8 +28,4 @@ rbd-mirror0
 
 [all:vars]
 debian_ceph_packages=['ceph', 'ceph-common', 'ceph-fuse']
-nfs_ganesha_stable=True
-nfs_ganesha_stable_branch="V2.7-stable"
 nfs_ganesha_stable_deb_repo="{{ ceph_mirror }}/nfs-ganesha/deb-{{ nfs_ganesha_stable_branch }}/{{ ceph_stable_release }}"
-nfs_ganesha_dev=False
-nfs_ganesha_flavor="ceph_master"

diff --git a/tests/functional/dev_setup.yml b/tests/functional/dev_setup.yml
index d8c35a5e1c7c5622612024b7e606016abd652921..b683987b6e12de033f11e194d1e0c251a26fc66e 100644 (file)
--- a/tests/functional/dev_setup.yml
+++ b/tests/functional/dev_setup.yml
@@ -9,28 +9,30 @@
     - block:
         - name: set_fact group_vars_path
           set_fact:
-            group_vars_path: "{{ change_dir + '/hosts' if 'ooo-collocation' in change_dir.split('/') else change_dir + '/group_vars/all' }}"
+            group_vars_path: "{{ change_dir + '/hosts' if 'ooo-collocation' in change_dir.split('/') else change_dir + '/group_vars' }}"
 
         - block:
             - name: change ceph_repository to 'dev'
               replace:
                 regexp: "ceph_repository:.*"
                 replace: "ceph_repository: dev"
-                dest: "{{ group_vars_path }}"
+                dest: "{{ group_vars_path }}/all"
 
-            - name: ensure nfs_ganesha_stable is set to False
-              replace:
-                regexp: "nfs_ganesha_stable=.*"
-                replace: "nfs_ganesha_stable=False"
-                dest: "{{ group_vars_path }}"
+            - block:
+                - name: ensure nfs_ganesha_stable is set to False
+                  replace:
+                    regexp: "nfs_ganesha_stable:.*"
+                    replace: "nfs_ganesha_stable: false"
+                    dest: "{{ group_vars_path }}/nfss"
 
-            - name: ensure nfs_ganesha_dev is set to True
-              replace:
-                regexp: "nfs_ganesha_dev:.*"
-                replace: "nfs_ganesha_dev=True"
-                dest: "{{ group_vars_path }}"
+                - name: ensure nfs_ganesha_dev is set to True
+                  replace:
+                    regexp: "nfs_ganesha_dev:.*"
+                    replace: "nfs_ganesha_dev: true"
+                    dest: "{{ group_vars_path }}/nfss"
+              when: "'all_daemons' in group_vars_path.split('/')"
           when: change_dir is defined
 
-        - name: print contents of {{ group_vars_path }}
-          command: "cat {{ group_vars_path }}"
+        - name: print contents of {{ group_vars_path }}/all
+          command: "cat {{ group_vars_path }}/all"
       when: dev_setup

diff --git a/tests/functional/shrink_mon/hosts-ubuntu b/tests/functional/shrink_mon/hosts-ubuntu
index 6675222ed9c76f1ce3ccb281901f46fd6d9a0b6b..f2cc0b1252c3c8e8a996332f00ecd11588bccbac 100644 (file)
--- a/tests/functional/shrink_mon/hosts-ubuntu
+++ b/tests/functional/shrink_mon/hosts-ubuntu
@@ -5,31 +5,3 @@ mon2 monitor_address=192.168.1.12
 
 [osds]
 osd0
-osd1
-
-[mdss]
-mds0
-
-[rgws]
-rgw0
-
-[clients]
-client0
-client1
-
-#[nfss]
-#nfs0
-
-[rbdmirrors]
-rbd-mirror0
-
-[iscsigws]
-iscsi-gw0 ceph_repository="dev"
-
-[all:vars]
-debian_ceph_packages=['ceph', 'ceph-common', 'ceph-fuse']
-nfs_ganesha_stable=True
-nfs_ganesha_stable_branch="V2.7-stable"
-nfs_ganesha_stable_deb_repo="{{ ceph_mirror }}/nfs-ganesha/deb-{{ nfs_ganesha_stable_branch }}/{{ ceph_stable_release }}"
-nfs_ganesha_dev=False
-nfs_ganesha_flavor="ceph_master"