public_access: reuse formatter->dump_bool

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

diff --git a/src/rgw/rgw_public_access.cc b/src/rgw/rgw_public_access.cc
index 18dd878a9116d729d3c0516fa36ea8baa8a759b3..c36f779d220aef80516e699cce9300c5b82f269c 100644 (file)
--- a/src/rgw/rgw_public_access.cc
+++ b/src/rgw/rgw_public_access.cc
@@ -8,7 +8,6 @@ void PublicAccessConfiguration::decode_xml(XMLObj *obj) {
   RGWXMLDecoder::decode_xml("IgnorePublicAcls", IgnorePublicAcls, obj);
   RGWXMLDecoder::decode_xml("BlockPublicPolicy", BlockPublicPolicy, obj);
   RGWXMLDecoder::decode_xml("RestrictPublicBuckets", RestrictPublicBuckets, obj);
-  //  RGWXMLDecoder::decode_xml("BlockPublicAccessConfiguration", this, obj);
 }
 
 void PublicAccessConfiguration::dump_xml(Formatter *f) const {
@@ -18,10 +17,10 @@ void PublicAccessConfiguration::dump_xml(Formatter *f) const {
   // manually encode here
   auto bool_val = [](bool b) -> auto { return b ? "true": "false"; };
 
-  f->dump_string("BlockPublicAcls", bool_val(BlockPublicAcls));
-  f->dump_string("IgnorePublicAcls", bool_val(IgnorePublicAcls));
-  f->dump_string("BlockPublicPolicy", bool_val(BlockPublicPolicy));
-  f->dump_string("RestrictPublicBuckets", bool_val(RestrictPublicBuckets));
+  f->dump_bool("BlockPublicAcls", BlockPublicAcls);
+  f->dump_bool("IgnorePublicAcls", IgnorePublicAcls);
+  f->dump_bool("BlockPublicPolicy", BlockPublicPolicy);
+  f->dump_bool("RestrictPublicBuckets", RestrictPublicBuckets);
 }