]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commitdiff
Revert previous behavior of internal_key_skipped_count
authorsdong <siying.d@fb.com>
Tue, 1 Dec 2015 05:32:59 +0000 (21:32 -0800)
committersdong <siying.d@fb.com>
Tue, 1 Dec 2015 05:55:05 +0000 (21:55 -0800)
Summary: With recent commit 33e0c93826fd45640b24324a642ca03d8b9ef123, db iterator skips perf context counter internal_key_skipped_count when blindly issuing internal Next(). Now increment the counter by one when issuing this Next()

Test Plan: Run all existing tests

Reviewers: rven, yhchiang, IslamAbdelRahman, kradhakrishnan, igor, anthony

Reviewed By: anthony

Subscribers: yoshinorim, leveldb, dhruba

Differential Revision: https://reviews.facebook.net/D51465

db/db_iter.cc

index d04d30e9e5eb32c0854b60db4d808ede67565cf5..74558d56d821cc8bc0023e32714acf4725e686bb 100644 (file)
@@ -193,6 +193,7 @@ void DBIter::Next() {
     // If the current key is a merge, very likely iter already points
     // to the next internal position.
     iter_->Next();
+    PERF_COUNTER_ADD(internal_key_skipped_count, 1);
   }
 
   // Now we point to the next internal position, for both of merge and