]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
rgw: rgw_admin use raii for curl init/teardown
authorAbhishek Lekshmanan <abhishek@suse.com>
Mon, 5 Mar 2018 16:59:33 +0000 (17:59 +0100)
committerAbhishek Lekshmanan <abhishek@suse.com>
Mon, 5 Mar 2018 17:00:56 +0000 (18:00 +0100)
Since a lot of rgw-admin commands can exit early

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
src/rgw/rgw_admin.cc

index 821dac58b199e38cd83744dabf0e90737ba37344..6931422589727f1f0947f99feb839de5aaa7c14d 100644 (file)
@@ -3014,7 +3014,15 @@ int main(int argc, const char **argv)
 
   rgw_user_init(store);
   rgw_bucket_init(store->meta_mgr);
-  rgw::curl::setup_curl(boost::none);
+
+  struct rgw_curl_setup {
+    rgw_curl_setup() {
+      rgw::curl::setup_curl(boost::none);
+    }
+    ~rgw_curl_setup() {
+      rgw::curl::cleanup_curl();
+    }
+  } curl_cleanup;
 
   StoreDestructor store_destructor(store);
 
@@ -7247,6 +7255,5 @@ next:
     }
   }
 
-  rgw::curl::cleanup_curl();
   return 0;
 }