]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mgr/dashboard: fix setting compression type while editing rgw zone
authorAashish Sharma <aasharma@li-e74156cc-2f67-11b2-a85c-e98659a63c5c.ibm.com>
Mon, 23 Sep 2024 08:28:22 +0000 (13:58 +0530)
committerAashish Sharma <aasharma@li-e74156cc-2f67-11b2-a85c-e98659a63c5c.ibm.com>
Wed, 25 Sep 2024 08:28:34 +0000 (13:58 +0530)
Fixes: https://tracker.ceph.com/issues/68176
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit ff7aa420b1abc5b1ecc03804ccc6fe8bdb962704)

src/pybind/mgr/dashboard/services/rgw_client.py

index aed70260362ef367115a4d4ff74441e174cf737c..b39ba30479e522c859a65bc0894408ec9a928278 100644 (file)
@@ -1492,8 +1492,9 @@ class RgwMultisite:
         rgw_zone_add_storage_class_cmd = ['zone', 'placement', 'add', '--rgw-zone', zone_name,
                                           '--placement-id', placement_target,
                                           '--storage-class', storage_class,
-                                          '--data-pool', data_pool,
-                                          '--compression', compression]
+                                          '--data-pool', data_pool]
+        if compression:
+            rgw_zone_add_storage_class_cmd.extend(['--compression', compression])
         try:
             exit_code, _, err = mgr.send_rgwadmin_command(rgw_zone_add_storage_class_cmd)
             if exit_code > 0: