]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commitdiff
drm/msm: Adjust msm_iommu_pagetable_prealloc_allocate() allocation type
authorKees Cook <kees@kernel.org>
Fri, 6 Feb 2026 22:21:52 +0000 (14:21 -0800)
committerKees Cook <kees@kernel.org>
Thu, 19 Feb 2026 18:07:01 +0000 (10:07 -0800)
In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "void **" but the returned type will be "void ***".
These are the same allocation size (pointer size), but the types do not
match. Adjust the allocation type to match the assignment.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://patch.msgid.link/20260206222151.work.016-kees@kernel.org
Signed-off-by: Kees Cook <kees@kernel.org>
drivers/gpu/drm/msm/msm_iommu.c

index d5dede4ff7619fc27ee114780768e997e36f40e1..271baf4dc4e80b0aeea1d7f05083f93115134aca 100644 (file)
@@ -332,7 +332,7 @@ msm_iommu_pagetable_prealloc_allocate(struct msm_mmu *mmu, struct msm_mmu_preall
        struct kmem_cache *pt_cache = get_pt_cache(mmu);
        int ret;
 
-       p->pages = kvmalloc_array(p->count, sizeof(p->pages), GFP_KERNEL);
+       p->pages = kvmalloc_array(p->count, sizeof(*p->pages), GFP_KERNEL);
        if (!p->pages)
                return -ENOMEM;