]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commitdiff
Using return value of fwrite in posix_logger.h
authorMayank Agarwal <amayank@fb.com>
Fri, 15 Mar 2013 01:12:22 +0000 (18:12 -0700)
committerMayank Agarwal <amayank@fb.com>
Wed, 20 Mar 2013 04:33:01 +0000 (21:33 -0700)
Summary: Was causing error(warning) in third-party saying unused result

Test Plan: make

Reviewers: sheki, dhruba

Reviewed By: dhruba

Differential Revision: https://reviews.facebook.net/D9447

util/posix_logger.h

index b1fbfd97ff45741d7e18609274573ca0828d3719..ac6615e97435e1d41b7e29b291d6571fd0802497 100644 (file)
@@ -111,11 +111,12 @@ class PosixLogger : public Logger {
       }
 #endif
 
-      fwrite(base, 1, write_size, file_);
-      fflush(file_);
-
-      log_size_ += write_size;
-
+      size_t sz = fwrite(base, 1, write_size, file_);
+      assert(sz == write_size);
+      if (sz > 0) {
+        fflush(file_);
+        log_size_ += write_size;
+      }
       if (base != buffer) {
         delete[] base;
       }