]> git-server-git.apps.pok.os.sepia.ceph.com Git - teuthology.git/commitdiff
rgw.py: add None object check when parsing info
authorJoe Buck <jbbuck@gmail.com>
Sun, 4 Aug 2013 00:16:52 +0000 (17:16 -0700)
committerJoe Buck <jbbuck@gmail.com>
Sun, 4 Aug 2013 00:16:52 +0000 (17:16 -0700)
The rgw task was failing to check for a None object
when parsing user info in the case where there were
config options set for the client that did not include
user info (e.g. valgrind: ).

teuthology/task/rgw.py

index f48d860db969fa3eff7c634da36e9ab0d9f947e5..177e81167ba68b0c9540a02d15babd4e94ccfcef 100644 (file)
@@ -350,20 +350,23 @@ def configure_users(ctx, config):
         if not c_config:
             continue
         user_info = extract_user_info(c_config)
-        log.debug('Creating user {user} on {client}'.format(
-                  user=user_info['system_key']['user'],client=client))
-        rgwadmin(ctx, client,
-                 cmd=[
-                     '-n', client,
-                     'user', 'create',
-                     '--uid', user_info['system_key']['user'],
-                     '--access-key', user_info['system_key']['access_key'],
-                     '--secret', user_info['system_key']['secret_key'],
-                     '--display-name', user_info['system_key']['user'],
-                     '--system',
-                     ],
-                 check_status=True,
-                 )
+
+        # if user_info was successfully parsed, use it to create a user
+        if user_info is not None:
+            log.debug('Creating user {user} on {client}'.format(
+                      user=user_info['system_key']['user'],client=client))
+            rgwadmin(ctx, client,
+                    cmd=[
+                        '-n', client,
+                        'user', 'create',
+                        '--uid', user_info['system_key']['user'],
+                        '--access-key', user_info['system_key']['access_key'],
+                        '--secret', user_info['system_key']['secret_key'],
+                        '--display-name', user_info['system_key']['user'],
+                        '--system',
+                        ],
+                    check_status=True,
+                    )
 
     yield