]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
test_shared_cache: fix memory leak.
authorJianpeng Ma <jianpeng.ma@intel.com>
Thu, 22 Nov 2018 07:36:40 +0000 (15:36 +0800)
committerJianpeng Ma <jianpeng.ma@intel.com>
Thu, 22 Nov 2018 07:36:40 +0000 (15:36 +0800)
Based on SharedLRU::add,  If the key already existed, you are
responsible for deleting the new value you tried to insert.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
src/test/common/test_shared_cache.cc

index 8db5d9ce37c7ecdd095ef2b66edc5276acaf8531..eeb526236c9b824eb2c67b62a3352ef1fd72ba7f 100644 (file)
@@ -109,9 +109,11 @@ TEST_F(SharedLRU_all, add) {
   }
   {
     int value2 = 3;
-    std::shared_ptr<int> ptr = cache.add(key, new int(value2), &existed);
+    auto p = new int(value2);
+    std::shared_ptr<int> ptr = cache.add(key, p, &existed);
     ASSERT_EQ(value1, *ptr);
     ASSERT_TRUE(existed);
+    delete p;
   }
 }
 TEST_F(SharedLRU_all, empty) {