]> git.apps.os.sepia.ceph.com Git - ceph-ansible.git/commitdiff
common: replace shell module
authorGuillaume Abrioux <gabrioux@redhat.com>
Wed, 14 Aug 2019 09:10:12 +0000 (11:10 +0200)
committerGuillaume Abrioux <gabrioux@redhat.com>
Wed, 14 Aug 2019 14:42:02 +0000 (16:42 +0200)
there is no need to use `shell` in these tasks. Let's use `command`.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
roles/ceph-facts/tasks/facts.yml
roles/ceph-mon/tasks/deploy_monitors.yml

index 8cb8dab912816a910750ee0943d1e49e35b67a6b..21c2d7ab3283e30c566cc988a4f41cb753b194cd 100644 (file)
     - not rolling_update | bool
   block:
   - name: generate cluster fsid
-    shell: "{{ discovered_interpreter_python }} -c 'import uuid; print(str(uuid.uuid4()))'"
+    command: "{{ discovered_interpreter_python }} -c 'import uuid; print(str(uuid.uuid4()))'"
     register: cluster_uuid
     delegate_to: "{{ groups[mon_group_name][0] }}"
     run_once: true
index cf83466668e49399b330799528f6e6c0bf2846a5..893ddde48ae53a85c6b89302cabd70c67b07bcbf 100644 (file)
@@ -10,7 +10,7 @@
   when: ceph_current_status.fsid is defined
 
 - name: generate monitor initial keyring
-  shell: >
+  command: >
     {{ discovered_interpreter_python }} -c "import os ; import struct ;
     import time; import base64 ; key = os.urandom(16) ;
     header = struct.pack('<hiih',1,int(time.time()),0,len(key)) ;