common: do not use `shell` module when it is not needed

There is no need here to use `shell` instead of `command`

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit dd0c98c5a2e9e26bca60e00564ea2018984545f6)
Signed-off-by: Sébastien Han <seb@redhat.com>

diff --git a/infrastructure-playbooks/purge-cluster.yml b/infrastructure-playbooks/purge-cluster.yml
index c04c408a5a95d9b9a3b3f7f6a3efa1246cde0448..e2b1478c234757066dcd8259413b7a0f451fc501 100644 (file)
--- a/infrastructure-playbooks/purge-cluster.yml
+++ b/infrastructure-playbooks/purge-cluster.yml
@@ -288,7 +288,9 @@
     ignore_errors: true
 
   - name: is reboot needed
-    local_action: shell echo requesting reboot
+    local_action:
+      module: command
+        echo requesting reboot
     become: false
     notify:
       - restart machine
@@ -563,7 +565,9 @@
      state: absent
 
   - name: request data removal
-    local_action: shell echo requesting data removal
+    local_action:
+      module: command
+        echo requesting data removal
     become: false
     notify:
       - remove data

diff --git a/roles/ceph-common/tasks/checks/check_firewall.yml b/roles/ceph-common/tasks/checks/check_firewall.yml
index 458da0711591a234b3a5cb2c0198b9c6af7253da..15c0623d2240cc24a1eeb1083a3441ababbdd5b5 100644 (file)
--- a/roles/ceph-common/tasks/checks/check_firewall.yml
+++ b/roles/ceph-common/tasks/checks/check_firewall.yml
@@ -1,6 +1,8 @@
 ---
 - name: check if nmap is installed
-  local_action: shell command -v nmap
+  local_action:
+    module: command
+      command -v nmap
   changed_when: false
   failed_when: false
   register: nmapexist