Makefile: error out of 'install' if COPYOPTS is set

Since https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/319
and https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/331 ,
doing `make COPYOPTS="blahblah" install` does not fail, but does
not do what it did before. This is a surprising and possibly
undesired result (in Fedora, it led to our firmware suddenly
taking up 500MB more space on disk, and that led to a bunch of
live image builds failing).

To make the change more apparent, let's just fail out with an
explanatory message if invoked with COPYOPTS set.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
Co-authored by: Emil Velikov <emil.l.velikov@gmail.com>

diff --git a/Makefile b/Makefile
index 033e3fb671d3dd63ae984c1769a1d1876b0fea08..3f51b4eff1f55e398a149f34c72215ce28db8b4b 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -30,6 +30,11 @@ dedup:
        ./dedup-firmware.sh $(DESTDIR)$(FIRMWAREDIR)
 
 install:
+       @if [ -n "${COPYOPTS}" ]; then \
+               echo "COPYOPTS is not used since linux-firmware-20241017!"; \
+               echo "You may want to use install{-xz,-zst} and dedup targets instead"; \
+               false; \
+       fi
        install -d $(DESTDIR)$(FIRMWAREDIR)
        ./copy-firmware.sh $(DESTDIR)$(FIRMWAREDIR)
        @echo "Now run \"make dedup\" to de-duplicate any firmware files"