]> git-server-git.apps.pok.os.sepia.ceph.com Git - xfsprogs-dev.git/commitdiff
xfs: fix returned valued from xfs_defer_can_append
authorCarlos Maiolino <cem@kernel.org>
Mon, 23 Mar 2026 18:33:19 +0000 (11:33 -0700)
committerAndrey Albershteyn <aalbersh@kernel.org>
Wed, 8 Apr 2026 19:39:57 +0000 (21:39 +0200)
Source kernel commit: 54fcd2f95f8d216183965a370ec69e1aab14f5da

xfs_defer_can_append returns a bool, it shouldn't be returning
a NULL.

Found by code inspection.

Fixes: 4dffb2cbb483 ("xfs: allow pausing of pending deferred work items")
Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Acked-by: Souptick Joarder <souptick.joarder@hpe.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
libxfs/xfs_defer.c

index e4d17177f67fafa53485aa17315479211d639026..3e36865fd1279fecb03cf603102f5b7c33268d7b 100644 (file)
@@ -802,7 +802,7 @@ xfs_defer_can_append(
 
        /* Paused items cannot absorb more work */
        if (dfp->dfp_flags & XFS_DEFER_PAUSED)
-               return NULL;
+               return false;
 
        /* Already full? */
        if (ops->max_items && dfp->dfp_count >= ops->max_items)