fix non skipped task for ansible v1.9.x

please refer to
https://bugzilla.redhat.com/show_bug.cgi?id=1376283

Signed-off-by: Sébastien Han <seb@redhat.com>
(cherry picked from commit f162db1202a050d363820fc838e7df41ff9ce3d8)

Conflicts:
	roles/ceph-osd/tasks/activate_osds.yml
	roles/ceph-osd/tasks/check_devices.yml

Resolves: rhbz#1388885

diff --git a/roles/ceph-osd/tasks/activate_osds.yml b/roles/ceph-osd/tasks/activate_osds.yml
index f37c3eb820a3411131ef21cc630d19125c831414..64dbad18e8e406485574b4a80b2be1a3a4d253d9 100644 (file)
--- a/roles/ceph-osd/tasks/activate_osds.yml
+++ b/roles/ceph-osd/tasks/activate_osds.yml
@@ -63,7 +63,7 @@
     msg: "ceph-disk failed to create an OSD"
   when:
     " 'ceph-disk: Error: ceph osd create failed' in item.get('stderr', '') "
-  with_items: "{{combined_activate_osd_disk_results.results}}"
+  with_items: "{{ (combined_activate_osd_disk_results|default({})).results|default([]) }}"
 
 # NOTE (leseb): this task is for partitions because we don't explicitly use a partition.
 - name: activate osd(s) when device is a partition
@@ -113,7 +113,7 @@
   command: systemctl enable ceph-osd@{{ item }}
   changed_when: false
   failed_when: false
-  with_items: osd_id.stdout_lines
+  with_items: "{{ (osd_id|default({})).stdout_lines|default([]) }}"
   when:
     use_systemd and
     is_after_hammer
@@ -123,7 +123,7 @@
     name: ceph-osd@{{ item }}
     state: started
     enabled: yes
-  with_items: osd_id.stdout_lines
+  with_items: "{{ (osd_id|default({})).stdout_lines|default([]) }}"
   changed_when: false
   when:
     use_systemd and

diff --git a/roles/ceph-osd/tasks/check_devices.yml b/roles/ceph-osd/tasks/check_devices.yml
index abda067899f402f3c46863ff05c8fe707a811af6..c916ff45cc3c1be167ad4f947d73c38d5417c145 100644 (file)
--- a/roles/ceph-osd/tasks/check_devices.yml
+++ b/roles/ceph-osd/tasks/check_devices.yml
@@ -68,7 +68,7 @@
 
 - name: check the partition status of the journal devices
   shell: "parted --script {{ item }} print > /dev/null 2>&1"
-  with_items: raw_journal_devices
+  with_items: "{{ raw_journal_devices|default([])|unique }}"
   changed_when: false
   failed_when: false
   register: journal_partition_status