Unpin gevent and avoid patching subprocess

Recently, gevent updated to 1.1.0, breaking a few things like misc.sh().
PR #810 pinned gevent to 1.0.2, but I wanted to properly investigate the
issue to not be stuck on an old version. Some git bisects later, I
discovered that gevent began patching the subprocess module by default
in:

https://github.com/gevent/gevent/commit/fc73e9afa34d811ede5d62531025d2e3876b8c01

Unpinning gevent and also telling it not to patch subprocess fixes the
issue.

Signed-off-by: Zack Cerza <zack@redhat.com>

diff --git a/setup.py b/setup.py
index 83de25f1bdaf4145a4714ecef13187cd09b624bb..ae368af2b3162346713e32dca848f38588b0a328 100644 (file)
--- a/setup.py
+++ b/setup.py
@@ -49,7 +49,7 @@ setup(
         'Topic :: System :: Filesystems',
     ],
     install_requires=['setuptools',
-                      'gevent == 1.0.2',
+                      'gevent',
                       'MySQL-python == 1.2.3',
                       'PyYAML',
                       'argparse >= 1.2.1',

diff --git a/teuthology/__init__.py b/teuthology/__init__.py
index d0bcfc0ab2f86bb3ba417d9ac44c01135f4c338d..e44c612eabc09281e36ceefe94c3af242b29f416 100644 (file)
--- a/teuthology/__init__.py
+++ b/teuthology/__init__.py
@@ -1,5 +1,9 @@
 from gevent import monkey
-monkey.patch_all(dns=False)
+monkey.patch_all(
+    dns=False,
+    # Don't patch subprocess to avoid http://tracker.ceph.com/issues/14990
+    subprocess=False,
+)
 from .orchestra import monkey
 monkey.patch_all()