xfs_scrub: read verification isn't ok if it hit runtime errors

Codex complains that a read-verify pool couldn't possibly be ok if
someone set the runtime_error field to a nonzero value.  That's true, so
fix the predicate.

Cc: linux-xfs@vger.kernel.org # v7.0.0
Fixes: 58fca77c2d2ae8 ("xfs_scrub: move failmap and other outputs into read_verify_pool")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Andrey Albershteyn <aalbersh@kernel.org>

diff --git a/scrub/read_verify.c b/scrub/read_verify.c
index 7dd588c1482af5229259c4e632298b17bff4e456..01e96f5bef40f69a38132bedbeb20fc0bb92beb9 100644 (file)
--- a/scrub/read_verify.c
+++ b/scrub/read_verify.c
@@ -557,7 +557,7 @@ bool
 read_verify_ok(
        const struct read_verify_pool   *rvp)
 {
-       return rvp->failmap == NULL && !rvp->truncated;
+       return rvp->failmap == NULL && !rvp->truncated && !rvp->runtime_error;
 }
 
 /* Did the verification unexpectedly stop early due to short reads? */