roles: Remove useless become (true) flag

We already set the become flag to true at a play level in the site*
playbooks so we don't need to set it at a task level.

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
(cherry picked from commit 7c3640177b6f6bdab15eb89866d8905ba38eda47)

diff --git a/roles/ceph-common/tasks/installs/configure_redhat_local_installation.yml b/roles/ceph-common/tasks/installs/configure_redhat_local_installation.yml
index 27a26ffd3bece2ee348793e653ecec4eed3c900d..2dc0ddfbd4c2856fa25adf0db7b81457ea13a313 100644 (file)
--- a/roles/ceph-common/tasks/installs/configure_redhat_local_installation.yml
+++ b/roles/ceph-common/tasks/installs/configure_redhat_local_installation.yml
@@ -19,7 +19,6 @@
 
 - name: install ceph dependencies
   script: "{{ ansible_dir }}/rundep_installer.sh {{ item }}"
-  become: true
   with_items: "{{ (rundep_location|default({})).stdout_lines|default([]) }}"
   when: use_installer | bool
 

diff --git a/roles/ceph-iscsi-gw/tasks/container/containerized.yml b/roles/ceph-iscsi-gw/tasks/container/containerized.yml
index 5b38d2f03ca0c814a5932092ba9c2ddc4d1bbe18..42280821f703f61a4173ecada0701834fd441dad 100644 (file)
--- a/roles/ceph-iscsi-gw/tasks/container/containerized.yml
+++ b/roles/ceph-iscsi-gw/tasks/container/containerized.yml
@@ -1,6 +1,5 @@
 ---
 - name: generate systemd unit files for tcmu-runner, rbd-target-api and rbd-target-gw
-  become: true
   template:
     src: "{{ role_path }}/templates/{{ item }}.service.j2"
     dest: /etc/systemd/system/{{ item }}.service

diff --git a/roles/ceph-mgr/tasks/start_mgr.yml b/roles/ceph-mgr/tasks/start_mgr.yml
index b243b1e145f2119a1589d00b87e5399bf028436c..3712152077e8bc4e9e6dc8805b9eea870d60ea3f 100644 (file)
--- a/roles/ceph-mgr/tasks/start_mgr.yml
+++ b/roles/ceph-mgr/tasks/start_mgr.yml
@@ -18,7 +18,6 @@
     - ansible_service_mgr == 'systemd'
 
 - name: generate systemd unit file
-  become: true
   template:
     src: "{{ role_path }}/templates/ceph-mgr.service.j2"
     dest: /etc/systemd/system/ceph-mgr@.service

diff --git a/roles/ceph-mon/tasks/start_monitor.yml b/roles/ceph-mon/tasks/start_monitor.yml
index dbf7d5198b15eade40e51300807dddb77f4b3dbd..56ef730cf004553029ccf39c90997e84ef933c60 100644 (file)
--- a/roles/ceph-mon/tasks/start_monitor.yml
+++ b/roles/ceph-mon/tasks/start_monitor.yml
@@ -20,7 +20,6 @@
     - ansible_service_mgr == 'systemd'
 
 - name: generate systemd unit file for mon container
-  become: true
   template:
     src: "{{ role_path }}/templates/ceph-mon.service.j2"
     dest: /etc/systemd/system/ceph-mon@.service

diff --git a/roles/ceph-nfs/tasks/pre_requisite_container.yml b/roles/ceph-nfs/tasks/pre_requisite_container.yml
index 9008a2bf3d365038583b7f370da110894e016691..0aa1ed75cab0c761b4eec35ff25e1c5e12d45f63 100644 (file)
--- a/roles/ceph-nfs/tasks/pre_requisite_container.yml
+++ b/roles/ceph-nfs/tasks/pre_requisite_container.yml
@@ -45,7 +45,6 @@
 - name: dbus related tasks
   block:
     - name: create dbus service file
-      become: true
       copy:
         src: "org.ganesha.nfsd.conf"
         dest: /etc/dbus-1/system.d/org.ganesha.nfsd.conf

diff --git a/roles/ceph-nfs/tasks/start_nfs.yml b/roles/ceph-nfs/tasks/start_nfs.yml
index ee10235265f75eef5d4575cad6652c8f8c04dd2b..bf888f070f3443ae9ce1db977c9a0b9f3a1b7220 100644 (file)
--- a/roles/ceph-nfs/tasks/start_nfs.yml
+++ b/roles/ceph-nfs/tasks/start_nfs.yml
@@ -61,7 +61,6 @@
   when: ceph_nfs_dynamic_exports | bool
 
 - name: generate systemd unit file
-  become: true
   template:
     src: "{{ role_path }}/templates/ceph-nfs.service.j2"
     dest: /etc/systemd/system/ceph-nfs@.service

diff --git a/roles/ceph-osd/tasks/start_osds.yml b/roles/ceph-osd/tasks/start_osds.yml
index d7c135c6b6ab9a62320d0a14ae2d54c9fb32dc5d..e2486701dbd136d0187ee02d9b641091beac75f9 100644 (file)
--- a/roles/ceph-osd/tasks/start_osds.yml
+++ b/roles/ceph-osd/tasks/start_osds.yml
@@ -11,7 +11,6 @@
     when: ceph_docker_on_openstack | bool
 
   - name: generate ceph osd docker run script
-    become: true
     template:
       src: "{{ role_path }}/templates/ceph-osd-run.sh.j2"
       dest: "{{ ceph_osd_docker_run_script_path }}/ceph-osd-run.sh"
@@ -39,7 +38,6 @@
   register: ceph_osd_ids
 
 - name: generate systemd unit file
-  become: true
   template:
     src: "{{ role_path }}/templates/ceph-osd.service.j2"
     dest: /etc/systemd/system/ceph-osd@.service

diff --git a/roles/ceph-rbd-mirror/tasks/docker/start_docker_rbd_mirror.yml b/roles/ceph-rbd-mirror/tasks/docker/start_docker_rbd_mirror.yml
index d863127e27d787e3542dd55f1744e1761d3a4616..36ded05cab4f197f933f61248da0733e7e2f7b86 100644 (file)
--- a/roles/ceph-rbd-mirror/tasks/docker/start_docker_rbd_mirror.yml
+++ b/roles/ceph-rbd-mirror/tasks/docker/start_docker_rbd_mirror.yml
@@ -1,7 +1,6 @@
 ---
 # Use systemd to manage container on Atomic host
 - name: generate systemd unit file
-  become: true
   template:
     src: "{{ role_path }}/templates/ceph-rbd-mirror.service.j2"
     dest: /etc/systemd/system/ceph-rbd-mirror@.service

diff --git a/roles/ceph-rgw/tasks/docker/start_docker_rgw.yml b/roles/ceph-rgw/tasks/docker/start_docker_rgw.yml
index ddc2624363a205bf53f37610dbb3924cb948b83e..0346b96876f364b6c6252ac6e312afd38cca15fb 100644 (file)
--- a/roles/ceph-rgw/tasks/docker/start_docker_rgw.yml
+++ b/roles/ceph-rgw/tasks/docker/start_docker_rgw.yml
@@ -1,6 +1,5 @@
 ---
 - name: generate environment file
-  become: true
   copy:
     dest: "/var/lib/ceph/radosgw/{{ cluster }}-rgw.{{ ansible_hostname }}.{{ item.instance_name }}/EnvironmentFile"
     owner: "root"
@@ -12,7 +11,6 @@
   with_items: "{{ rgw_instances }}"
 
 - name: generate systemd unit file
-  become: true
   template:
     src: "{{ role_path }}/templates/ceph-radosgw.service.j2"
     dest: /etc/systemd/system/ceph-radosgw@.service