Bluetooth: hci_qca: Cleanup on all setup failures

The setup process previously combined error handling and retry gating
under one condition. As a result, the final failed attempt exited
without performing cleanup.

Update the failure path to always perform power and port cleanup on
setup failure, and reopen the port only when retrying.

Fixes: 9e80587aba4c ("Bluetooth: hci_qca: Enhance retry logic in qca_setup")
Signed-off-by: Jinwang Li <jinwang.li@oss.qualcomm.com>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index c511546f793e4bbef36f247b0d28173d732f6854..c6de2602b49d051eb0dc040fde986405210e5963 100644 (file)
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -2046,19 +2046,23 @@ retry:
        }
 
 out:
-       if (ret && retries < MAX_INIT_RETRIES) {
-               bt_dev_warn(hdev, "Retry BT power ON:%d", retries);
+       if (ret) {
                qca_power_shutdown(hu);
-               if (hu->serdev) {
-                       serdev_device_close(hu->serdev);
-                       ret = serdev_device_open(hu->serdev);
-                       if (ret) {
-                               bt_dev_err(hdev, "failed to open port");
-                               return ret;
+
+               if (retries < MAX_INIT_RETRIES) {
+                       bt_dev_warn(hdev, "Retry BT power ON:%d", retries);
+                       if (hu->serdev) {
+                               serdev_device_close(hu->serdev);
+                               ret = serdev_device_open(hu->serdev);
+                               if (ret) {
+                                       bt_dev_err(hdev, "failed to open port");
+                                       return ret;
+                               }
                        }
+                       retries++;
+                       goto retry;
                }
-               retries++;
-               goto retry;
+               return ret;
        }
 
        /* Setup bdaddr */