GitbuilderProject: remove 'v' from version values

Some version values have a leading 'v', e.g.:
http://gitbuilder.ceph.com/ceph-rpm-centos7-x86_64-basic/ref/v10.2.0/version
is 'v10.2.0', whereas:
http://gitbuilder.ceph.com/ceph-rpm-centos7-x86_64-basic/ref/jewel/version
is '10.2.3-0'.

Signed-off-by: Zack Cerza <zack@redhat.com>

diff --git a/teuthology/packaging.py b/teuthology/packaging.py
index 860e9764e8a430b697a3a3f84af9614a3aaee27e..80b8d9d003fb18628d82594540900d8575cdba31 100644 (file)
--- a/teuthology/packaging.py
+++ b/teuthology/packaging.py
@@ -732,7 +732,7 @@ class GitbuilderProject(object):
 
         if not resp.ok:
             raise VersionNotFoundError(url)
-        version = resp.text.strip()
+        version = resp.text.strip().lstrip('v')
         log.info("Found version: {0}".format(version))
         return version
 

diff --git a/teuthology/test/test_packaging.py b/teuthology/test/test_packaging.py
index fc56caca881d26f82aafea8066bbc71892bcb2e0..9c466a750065a7e61e004b6ed127964f7afa76ed 100644 (file)
--- a/teuthology/test/test_packaging.py
+++ b/teuthology/test/test_packaging.py
@@ -573,6 +573,14 @@ class TestGitbuilderProject(TestBuilderProject):
         super(TestGitbuilderProject, self)\
             .test_get_package_version_found()
 
+    def test_version_strip_v(self):
+        resp = Mock()
+        resp.ok = True
+        resp.text = "v0.90.0"
+        self.m_get_response.return_value = resp
+        super(TestGitbuilderProject, self)\
+            .test_get_package_version_found()
+
     def test_get_package_sha1_fetched_found(self):
         resp = Mock()
         resp.ok = True