]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mgr/dashboard: migrate nvmeof pr #1238 to new cli
authorTomer Haskalovitch <il033030@Tomers-MBP.lan>
Mon, 23 Jun 2025 20:23:05 +0000 (23:23 +0300)
committerTomer Haskalovitch <tomer.haska@ibm.com>
Sun, 6 Jul 2025 07:43:07 +0000 (10:43 +0300)
Signed-off-by: Tomer Haskalovitch <tomer.haska@ibm.com>
(cherry picked from commit 4c6304e7ff1e2df469b7f6e26337e5cfa13bc4b2)

src/pybind/mgr/dashboard/controllers/nvmeof.py
src/pybind/mgr/dashboard/model/nvmeof.py

index a0e1fb9404f88ff85a29a0ab5ca82bf262125667..1111523ae090d853ad04a598257b6aa6b3b44eb5 100644 (file)
@@ -604,7 +604,9 @@ else:
         @NvmeofCLICommand("nvmeof connection list", model.ConnectionList)
         @convert_to_model(model.ConnectionList)
         @handle_nvmeof_error
-        def list(self, nqn: str, gw_group: Optional[str] = None, traddr: Optional[str] = None):
+        def list(self, nqn: Optional[str] = None, gw_group: Optional[str] = None, traddr: Optional[str] = None):
+            if not nqn:
+                nqn = '*'
             return NVMeoFClient(gw_group=gw_group, traddr=traddr).stub.list_connections(
                 NVMeoFClient.pb2.list_connections_req(subsystem=nqn)
             )
index 0c3cf4c7907d76ab66d8f1bf52e3959ef23c9f8b..330265879c469475666250f03852c0cb14999297 100644 (file)
@@ -88,6 +88,7 @@ class Connection(NamedTuple):
     connected: bool
     qpairs_count: int
     controller_id: int
+    subsystem: Optional[str]
 
 
 class ConnectionList(NamedTuple):