ceph-validate: check devices from lvm_volumes

2888c08 introduced a regression as the check_devices tasks file was
only included based on the devices variable.
But that file also validate some devices from the lvm_volumes variable.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1906022
Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
(cherry picked from commit ac0342b72e045b96a31bed23c6baeceeecca7f23)

diff --git a/roles/ceph-validate/tasks/check_devices.yml b/roles/ceph-validate/tasks/check_devices.yml
index 5f439ac6a4d469b8cfd4da4e33ff33fd11be693d..930f45431b041c58cc7244b24bca2c70f2ff8594 100644 (file)
--- a/roles/ceph-validate/tasks/check_devices.yml
+++ b/roles/ceph-validate/tasks/check_devices.yml
@@ -83,7 +83,7 @@
         unit: MiB
       register: devices_parted
       failed_when: False
-      with_items: "{{ devices }}"
+      with_items: "{{ devices | default([]) }}"
 
     - name: fail if one of the devices is not a device
       fail:

diff --git a/roles/ceph-validate/tasks/main.yml b/roles/ceph-validate/tasks/main.yml
index 51c2fac28f728335bb80f3f75dcb3d051a1fd8db..ae989b0fc97fc9bc6b2ba896d2ed468eadca8310 100644 (file)
--- a/roles/ceph-validate/tasks/main.yml
+++ b/roles/ceph-validate/tasks/main.yml
@@ -140,7 +140,6 @@
   when:
     - osd_group_name in group_names
     - not osd_auto_discovery | default(False) | bool
-    - devices|default([])|length > 0
 
 - name: include check_eth_mon.yml
   include_tasks: check_eth_mon.yml