]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-build.git/commitdiff
ceph-release-pipeline: pass boolean parameters as booleans
authorDavid Galloway <david.galloway@ibm.com>
Thu, 9 Jul 2026 16:28:45 +0000 (12:28 -0400)
committerDavid Galloway <david.galloway@ibm.com>
Thu, 9 Jul 2026 19:08:05 +0000 (15:08 -0400)
The ceph-dev-pipeline and second ceph-tag invocations passed env values
(strings) straight to booleanParam, unlike the first ceph-tag
invocation which converts with .toBoolean().  Downstream now compares
params.THROWAWAY == false strictly, so make sure the values arrive as
actual booleans.

Signed-off-by: David Galloway <david.galloway@ibm.com>
ceph-release-pipeline/build/Jenkinsfile

index 9af3331f3524d2ea2ead5c0b688d4fae43794c01..b064d126d61841a6f6bb270ecd1d5a8198172839 100644 (file)
@@ -59,8 +59,8 @@ pipeline {
               string(name: "ARCHS",               value: env.ARCHS),
               string(name: "FLAVORS",             value: 'default'),
               booleanParam(name: "CI_COMPILE",    value: true),
-              booleanParam(name: "THROWAWAY",     value: env.THROWAWAY),
-              booleanParam(name: "FORCE",         value: env.FORCE),
+              booleanParam(name: "THROWAWAY",     value: env.THROWAWAY?.toBoolean()),
+              booleanParam(name: "FORCE",         value: env.FORCE?.toBoolean()),
               string(name: 'FLAVOR',              value: 'default'),
               // Release containers are built manually from signed packages so we don't need to build them here
               booleanParam(name: 'CI_CONTAINER',  value: false),
@@ -85,10 +85,10 @@ pipeline {
             parameters: [
               string(name: 'VERSION',             value: env.VERSION ?: ''),
               string(name: 'BRANCH',              value: env.BRANCH ?: ''),
-              booleanParam(name: 'FORCE_VERSION', value: env.FORCE_VERSION),
+              booleanParam(name: 'FORCE_VERSION', value: env.FORCE_VERSION?.toBoolean()),
               string(name: 'RELEASE_TYPE',        value: env.RELEASE_TYPE ?: ''),
               booleanParam(name: 'RELEASE_BUILD', value: true),
-              booleanParam(name: 'TAG',           value: env.TAG),
+              booleanParam(name: 'TAG',           value: env.TAG?.toBoolean()),
               string(name: 'TAG_PHASE',           value: 'push')
             ],
           )