]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mgr/vol: improve dump() of trash.py
authorRishabh Dave <ridave@redhat.com>
Sat, 29 Mar 2025 11:21:31 +0000 (16:51 +0530)
committerRishabh Dave <ridave@redhat.com>
Fri, 21 Nov 2025 06:07:57 +0000 (11:37 +0530)
"path" doesn't clearly specify what path that variable contains. Rename
it to something more specific and more descriptive based on its
contents.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
src/pybind/mgr/volumes/fs/operations/trash.py

index 29d155f7a662a59b4e77ab5b6473715fb5b71028..80ff86a8dc1528d68a6897328b67580e5a63cb31 100644 (file)
@@ -76,15 +76,15 @@ class Trash(GroupTemplate):
         except cephfs.Error as e:
             raise VolumeException(-e.args[0], e.args[1])
 
-    def dump(self, path):
+    def dump(self, SRC_PATH):
         """
         move an filesystem entity to trash can.
 
-        :praram path: the filesystem path to be moved
+        :praram SRC_PATH: the filesystem SRC_PATH to be moved
         :return: None
         """
         try:
-            self.fs.rename(path, self.unique_trash_path)
+            self.fs.rename(SRC_PATH, self.unique_trash_path)
         except cephfs.Error as e:
             raise VolumeException(-e.args[0], e.args[1])