disable UBSAN for functions with intentional -ve shift / overflow

Summary:
disable UBSAN for functions with intentional left shift on -ve number / overflow

These functions are
rocksdb:: Hash
FixedLengthColBufEncoder::Append
FaultInjectionTest:: Key
Closes https://github.com/facebook/rocksdb/pull/1577

Differential Revision: D4240801

Pulled By: IslamAbdelRahman

fbshipit-source-id: 3e1caf6

diff --git a/db/fault_injection_test.cc b/db/fault_injection_test.cc
index 8200de1b6d66c91d80c3926f96166f7729cf6ca6..d06db2847d1a739277107f05429c27265a2fe8bd 100644 (file)
--- a/db/fault_injection_test.cc
+++ b/db/fault_injection_test.cc
@@ -228,6 +228,11 @@ class FaultInjectionTest : public testing::Test,
     return Status::OK();
   }
 
+#if defined(__clang__)
+__attribute__((__no_sanitize__("undefined")))
+#elif __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 9)
+__attribute__((__no_sanitize_undefined__))
+#endif
   // Return the ith key
   Slice Key(int i, std::string* storage) const {
     int num = i;

diff --git a/util/hash.cc b/util/hash.cc
index dfd2dc40367da0fdc4f03af1e9181772e7b5f9bd..ce0790a8fee21c9fdb65003377b0ef5c17ec54e8 100644 (file)
--- a/util/hash.cc
+++ b/util/hash.cc
@@ -13,6 +13,12 @@
 
 namespace rocksdb {
 
+// This function may intentionally do a left shift on a -ve number
+#if defined(__clang__)
+__attribute__((__no_sanitize__("undefined")))
+#elif __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 9)
+__attribute__((__no_sanitize_undefined__))
+#endif
 uint32_t Hash(const char* data, size_t n, uint32_t seed) {
   // Similar to murmur hash
   const uint32_t m = 0xc6a4a793;

diff --git a/utilities/col_buf_encoder.cc b/utilities/col_buf_encoder.cc
index fc5d6cdac7b5917a4279b7f7546f88c5553a8e48..f9098d4030c55359eb298fb0c4c73dcb909c3fce 100644 (file)
--- a/utilities/col_buf_encoder.cc
+++ b/utilities/col_buf_encoder.cc
@@ -46,6 +46,11 @@ ColBufEncoder *ColBufEncoder::NewColBufEncoder(
   return nullptr;
 }
 
+#if defined(__clang__)
+__attribute__((__no_sanitize__("undefined")))
+#elif __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 9)
+__attribute__((__no_sanitize_undefined__))
+#endif
 size_t FixedLengthColBufEncoder::Append(const char *buf) {
   if (nullable_) {
     if (buf == nullptr) {