]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mgr/DaemonServer: warn when we reject reports
authorSage Weil <sage@redhat.com>
Thu, 7 Nov 2019 18:51:04 +0000 (12:51 -0600)
committerSage Weil <sage@redhat.com>
Thu, 7 Nov 2019 18:51:04 +0000 (12:51 -0600)
If this is triggered it can be disruptive, since we're marking the
connection down.  It points to a real bug, so better visibility is good
(e.g., failing the teuthology jobs).

Signed-off-by: Sage Weil <sage@redhat.com>
src/mgr/DaemonServer.cc

index ccc5bd3eb8bd2cd1edbd5e1b11f5eb24a4db7143..6d086179c2c6febd9df49889dd4f089e19482815 100644 (file)
@@ -498,7 +498,9 @@ bool DaemonServer::handle_report(const ref_t<MMgrReport>& m)
     // Clients should not be sending us stats unless they are declaring
     // themselves to be a daemon for some service.
     dout(10) << "rejecting report from non-daemon client " << m->daemon_name
-           << dendl;
+            << dendl;
+    clog->warn() << "rejecting report from non-daemon client " << m->daemon_name
+                << " at " << m->get_connection()->get_peer_addrs();
     m->get_connection()->mark_down();
     return true;
   }