rpm: add rpm-build to SUSE-specific make check deps

The binary /usr/bin/rpmspec was recently moved to rpm-build, breaking
install-deps.sh on openSUSE Tumbleweed. The package is not strictly
needed for SLE-15-SP* and openSUSE Leap 15.*, but it doesn't hurt to
have it, and will future-proof these distros from this regression.

Putting the dependency in the spec file does not address the issue,
because /usr/bin/rpmspec must be available before install-deps.sh runs it to
determine the dependencies, but it's nice to have it explicitly listed there,
since it *is* a dependency of "make check" on SUSE distros.

SUSE versions < 15 are of no interest in master/octopus+.

Fixes: https://tracker.ceph.com/issues/42612
Signed-off-by: Nathan Cutler <ncutler@suse.com>

diff --git a/ceph.spec.in b/ceph.spec.in
index 3d936148823e972155e90e70250f250736ca5a6f..1adb2d7710861dc32668585a695304af2f70eb1e 100644 (file)
--- a/ceph.spec.in
+++ b/ceph.spec.in
@@ -313,6 +313,7 @@ BuildRequires:      python%{_python_buildid}-PyJWT
 BuildRequires: python%{_python_buildid}-Routes
 BuildRequires: python%{_python_buildid}-Werkzeug
 BuildRequires: python%{_python_buildid}-numpy-devel
+BuildRequires: rpm-build
 BuildRequires: xmlsec1-devel
 BuildRequires: xmlsec1-openssl-devel
 %endif

diff --git a/install-deps.sh b/install-deps.sh
index 621739a4a77e83afbcc67838fe0fe42831353a4a..36c3ebf1b2b3dec85fbcc301e1e6b3c86cee7c96 100755 (executable)
--- a/install-deps.sh
+++ b/install-deps.sh
@@ -424,7 +424,7 @@ else
     opensuse*|suse|sles)
         echo "Using zypper to install dependencies"
         zypp_install="zypper --gpg-auto-import-keys --non-interactive install --no-recommends"
-        $SUDO $zypp_install systemd-rpm-macros
+        $SUDO $zypp_install systemd-rpm-macros rpm-build || exit 1
         munge_ceph_spec_in $with_seastar $for_make_check $DIR/ceph.spec
         $SUDO $zypp_install $(rpmspec -q --buildrequires $DIR/ceph.spec) || exit 1
         ;;