node-proxy: adjust log levels

Let's adjust log levels across the project:

- use warning for bad request in the API,
  when thread is not alive and for retry failure,
- use error for OOB load failure,
- use info for backoff interval,
- use debug in send attempts and for member fetch

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>

diff --git a/src/ceph-node-proxy/ceph_node_proxy/api.py b/src/ceph-node-proxy/ceph_node_proxy/api.py
index 2e876568764b7681ea876a897034089089cdceef..0bb700820f04c1bc695634cd7f2923b1e51d1907 100644 (file)
--- a/src/ceph-node-proxy/ceph_node_proxy/api.py
+++ b/src/ceph-node-proxy/ceph_node_proxy/api.py
@@ -139,7 +139,7 @@ class API(Server):
 
         if "force" not in data.keys():
             msg = "The key 'force' wasn't passed."
-            self.log.debug(msg)
+            self.log.warning(msg)
             raise cherrypy.HTTPError(400, msg)
         try:
             result: int = self.backend.shutdown_host(force=data["force"])
@@ -172,14 +172,14 @@ class API(Server):
 
         if not led_type:
             msg = "the led type must be provided (either 'chassis' or 'drive')."
-            self.log.debug(msg)
+            self.log.warning(msg)
             raise cherrypy.HTTPError(400, msg)
 
         if led_type == "drive":
             id_drive_required = not id_drive
             if id_drive_required or id_drive not in self.backend.get_storage():
                 msg = "A valid device ID must be provided."
-                self.log.debug(msg)
+                self.log.warning(msg)
                 raise cherrypy.HTTPError(400, msg)
 
         try:
@@ -188,7 +188,7 @@ class API(Server):
 
                 if "state" not in data or data["state"] not in ["on", "off"]:
                     msg = "Invalid data. 'state' must be provided and have a valid value (on|off)."
-                    self.log.error(msg)
+                    self.log.warning(msg)
                     raise cherrypy.HTTPError(400, msg)
 
                 func: Any = (

diff --git a/src/ceph-node-proxy/ceph_node_proxy/main.py b/src/ceph-node-proxy/ceph_node_proxy/main.py
index a59faf4ac2e9b8d652277b7e865d8a284a4b4a75..dbd44391290db7491486778b49726281c14dfcf7 100644 (file)
--- a/src/ceph-node-proxy/ceph_node_proxy/main.py
+++ b/src/ceph-node-proxy/ceph_node_proxy/main.py
@@ -82,7 +82,7 @@ class NodeProxyManager:
             )
         except HTTPError as e:
             msg = f"No out of band tool details could be loaded: {e.code}, {e.reason}"
-            self.log.debug(msg)
+            self.log.error(msg)
             raise
 
         result_json = json.loads(result)
@@ -174,7 +174,7 @@ class NodeProxyManager:
                 self.init_system()
                 self.init_reporter()
                 check_interval = min(int(check_interval * backoff_factor), max_interval)
-                self.log.debug("Next check in %ds (backoff).", check_interval)
+                self.log.info("Next check in %ds (backoff).", check_interval)
             time.sleep(check_interval)
 
     def shutdown(self) -> None:

diff --git a/src/ceph-node-proxy/ceph_node_proxy/redfish.py b/src/ceph-node-proxy/ceph_node_proxy/redfish.py
index 71203c841075f81230ab8da98a8c88d0412bacd3..69ad1b4723a848b578743203ccc801c278d8c3e0 100644 (file)
--- a/src/ceph-node-proxy/ceph_node_proxy/redfish.py
+++ b/src/ceph-node-proxy/ceph_node_proxy/redfish.py
@@ -206,7 +206,7 @@ class Endpoint:
                     result[name] = self.data
             else:
                 for member, endpoint_url in members_endpoints.items():
-                    self.log.info(
+                    self.log.debug(
                         f"Fetching data for member: {member} at {endpoint_url}"
                     )
                     result[member] = self.query(endpoint_url)

diff --git a/src/ceph-node-proxy/ceph_node_proxy/reporter.py b/src/ceph-node-proxy/ceph_node_proxy/reporter.py
index 920db9c536cb67928dc5e3e2a62f01bcc17b7ec7..0e52f00f5ee1493dfed60bdaa1caf8a20c839664 100644 (file)
--- a/src/ceph-node-proxy/ceph_node_proxy/reporter.py
+++ b/src/ceph-node-proxy/ceph_node_proxy/reporter.py
@@ -43,7 +43,7 @@ class Reporter(BaseThread):
         """Send data to mgr. Returns True on success, False after max_retries failures."""
         for attempt in range(1, self.max_retries + 1):
             try:
-                self.log.info(
+                self.log.debug(
                     f"sending data to {self.reporter_url} (attempt {attempt}/{self.max_retries})"
                 )
                 http_req(

diff --git a/src/ceph-node-proxy/ceph_node_proxy/util.py b/src/ceph-node-proxy/ceph_node_proxy/util.py
index 8781553c5134d0b371813795c33d83ac8c2f3c2b..aa474624ae82d428784a83c2923372ebfef3ac4e 100644 (file)
--- a/src/ceph-node-proxy/ceph_node_proxy/util.py
+++ b/src/ceph-node-proxy/ceph_node_proxy/util.py
@@ -124,7 +124,7 @@ class BaseThread(threading.Thread):
             logger.error(f"Caught exception: {self.exc.__class__.__name__}")
             raise self.exc
         if not self.is_alive():
-            logger.info(f"{self.name} not alive")
+            logger.warning(f"{self.name} not alive")
             self.start()
         return True
 
@@ -162,7 +162,7 @@ def retry(
                 except exceptions:
                     time.sleep(delay)
                     _tries -= 1
-            logger.warn("{} has failed after {} tries".format(f, retries))
+            logger.warning("{} has failed after {} tries".format(f, retries))
             return f(*args, **kwargs)
 
         return _retry