]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mgr/cephadm: NodeAssignment.get_hosts_func now returns List[str]
authorSebastian Wagner <sebastian.wagner@suse.com>
Thu, 20 Feb 2020 09:39:28 +0000 (10:39 +0100)
committerSebastian Wagner <sebastian.wagner@suse.com>
Fri, 21 Feb 2020 09:21:31 +0000 (10:21 +0100)
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
src/pybind/mgr/cephadm/module.py

index da57a801a8ea130f91133e4966da4b592f49117d..e86da48eb4cacaa417e43f9809d79118f8c45549 100644 (file)
@@ -2469,7 +2469,7 @@ class NodeAssignment(object):
     def __init__(self,
                  spec=None,  # type: Optional[orchestrator.ServiceSpec]
                  scheduler=None,  # type: Optional[BaseScheduler]
-                 get_hosts_func=None,  # type: Optional[Callable]
+                 get_hosts_func=None,  # type: Optional[Callable[[],List[str]]]
                  service_type=None,  # type: Optional[str]
                  ):
         assert spec and get_hosts_func and service_type
@@ -2497,7 +2497,7 @@ class NodeAssignment(object):
         # NOTE: This currently queries for all hosts without label restriction
         if self.spec.placement.label:
             logger.info("Found labels. Assigning nodes that match the label")
-            candidates = [HostPlacementSpec(x[0], '', '') for x in self.get_hosts_func()]  # TODO: query for labels
+            candidates = [HostPlacementSpec(x, '', '') for x in self.get_hosts_func()]  # TODO: query for labels
             logger.info('Assigning nodes to spec: {}'.format(candidates))
             self.spec.placement.set_hosts(candidates)