Fix undefined collectd vars

We regressed by moving the definition of a couple of these vars. Set
them in a separate task file to avoid this in the future.

Signed-off-by: Zack Cerza <zack@redhat.com>

diff --git a/ansible/roles/ceph-collectd/tasks/configure_collectd.yml b/ansible/roles/ceph-collectd/tasks/configure_collectd.yml
index 97acfac3a4938e17c5ddc21f3efd48828f3779bf..9a295db2d58536e8b12c362a96a47a2bb10895e8 100644 (file)
--- a/ansible/roles/ceph-collectd/tasks/configure_collectd.yml
+++ b/ansible/roles/ceph-collectd/tasks/configure_collectd.yml
@@ -1,12 +1,4 @@
 ---
-- name: Set collectd_conf
-  set_fact:
-    collectd_conf: "/etc/{{ 'collectd/' if ansible_pkg_mgr == 'apt' else '' }}collectd.conf"
-
-- name: Set collectd_conf_d
-  set_fact:
-    collectd_conf_d: "/etc/collectd{{ '/collectd.conf' if ansible_pkg_mgr == 'apt' else '' }}.d"
-
 - name: Ship collectd.conf
   copy:
     src: files/etc/collectd.conf

diff --git a/ansible/roles/ceph-collectd/tasks/install_collectd_plugins.yml b/ansible/roles/ceph-collectd/tasks/install_collectd_plugins.yml
index 5af7367e51e62df089679f49dfe7b8234865cdec..8b4e61b1f4e9654838fbd53c1b2fdb126f381676 100644 (file)
--- a/ansible/roles/ceph-collectd/tasks/install_collectd_plugins.yml
+++ b/ansible/roles/ceph-collectd/tasks/install_collectd_plugins.yml
@@ -1,12 +1,4 @@
 ---
-- name: Set collectd_dir
-  set_fact:
-    collectd_dir: "/usr/lib{{ '64' if ansible_pkg_mgr == 'yum' else '' }}/collectd"
-
-- name: Set collectd_cephmetrics_dir
-  set_fact:
-    collectd_cephmetrics_dir: "{{ collectd_dir }}/cephmetrics"
-
 - name: Create collectors directory
   file:
     name: "{{ collectd_cephmetrics_dir }}/collectors"

diff --git a/ansible/roles/ceph-collectd/tasks/main.yml b/ansible/roles/ceph-collectd/tasks/main.yml
index afd77ed342ce356ab1c377001a1a20f37c8ac775..b56b81a80a74f72e2598203a1310ba53cb906bb4 100644 (file)
--- a/ansible/roles/ceph-collectd/tasks/main.yml
+++ b/ansible/roles/ceph-collectd/tasks/main.yml
@@ -15,6 +15,10 @@
   tags:
     - packages
 
+- include: set_collectd_vars.yml
+  tags:
+    - collectors
+
 - include: install_collectd_plugins.yml
   when:
     - not containerized_deployment

diff --git a/ansible/roles/ceph-collectd/tasks/set_collectd_vars.yml b/ansible/roles/ceph-collectd/tasks/set_collectd_vars.yml
new file mode 100644 (file)
index 0000000..8090240
--- /dev/null
+++ b/ansible/roles/ceph-collectd/tasks/set_collectd_vars.yml
@@ -0,0 +1,17 @@
+---
+- name: Set collectd_dir
+  set_fact:
+    collectd_dir: "/usr/lib{{ '64' if ansible_pkg_mgr == 'yum' else '' }}/collectd"
+
+- name: Set collectd_cephmetrics_dir
+  set_fact:
+    collectd_cephmetrics_dir: "{{ collectd_dir }}/cephmetrics"
+
+- name: Set collectd_conf
+  set_fact:
+    collectd_conf: "/etc/{{ 'collectd/' if ansible_pkg_mgr == 'apt' else '' }}collectd.conf"
+
+- name: Set collectd_conf_d
+  set_fact:
+    collectd_conf_d: "/etc/collectd{{ '/collectd.conf' if ansible_pkg_mgr == 'apt' else '' }}.d"
+