]> git.apps.os.sepia.ceph.com Git - teuthology.git/commitdiff
Stop obsuring stderr when installing with yum
authorZack Cerza <zack.cerza@inktank.com>
Tue, 14 Oct 2014 15:38:41 +0000 (09:38 -0600)
committerZack Cerza <zack.cerza@inktank.com>
Tue, 14 Oct 2014 15:47:56 +0000 (09:47 -0600)
Over time, the code that actually used the buffer we stored stderr in
was removed, leaving us holding error messages and never displaying
them.

Signed-off-by: Zack Cerza <zack.cerza@inktank.com>
teuthology/task/install.py

index c9efc04d620eb31ce12d59b4480deb4703f2d72f..df36c5a2f1e520e77306273c36d27c661896bdab 100644 (file)
@@ -479,7 +479,6 @@ def _update_rpm_package_list_and_install(ctx, remote, rpm, config):
         tmp_vers = tmp_vers.split('-')[0]
     ldir = _get_local_dir(config, remote)
     for cpack in rpm:
-        pk_err_mess = StringIO()
         pkg2add = "{cpack}-{version}".format(cpack=cpack, version=tmp_vers)
         pkg = None
         if ldir:
@@ -492,8 +491,7 @@ def _update_rpm_package_list_and_install(ctx, remote, rpm, config):
                         run.Raw(';'), 'fi']
             )
         if pkg is None:
-            remote.run(args=['sudo', 'yum', 'install', pkg2add, '-y', ],
-                    stderr=pk_err_mess)
+            remote.run(args=['sudo', 'yum', 'install', pkg2add, '-y'])
         else:
             remote.run(
                 args = ['if', 'test', run.Raw('!'), '-e',