common: admin socket catches exception by reference

probably not a real bug, but resolves a compiler warning:

src/common/admin_socket.cc: In member function ‘int RaiseHook::parse_signal(std::string&&, ceph::Formatter*, std::ostream&)’:
src/common/admin_socket.cc:869:21: warning: catching polymorphic type ‘class std::invalid_argument’ by value [-Wcatch-value=]
  869 |       } catch (std::invalid_argument) {
      |                     ^~~~~~~~~~~~~~~~

Fixes: https://tracker.ceph.com/issues/63455
Signed-off-by: Casey Bodley <cbodley@redhat.com>

diff --git a/src/common/admin_socket.cc b/src/common/admin_socket.cc
index 2ed3179e80709cbf222a8ba580345371bf3d3fb0..c4a37b29ed985132e59c970588cbcb6ffc276aef 100644 (file)
--- a/src/common/admin_socket.cc
+++ b/src/common/admin_socket.cc
@@ -866,7 +866,7 @@ class RaiseHook: public AdminSocketHook {
           errss << "signal number should be an integer in the range [1..64]" << std::endl;
           return -EINVAL;
         }
-      } catch (std::invalid_argument) {
+      } catch (const std::invalid_argument&) {
         auto sig_it = known_signals.find(sigdesc);
         if (sig_it == known_signals.end()) {
           errss << "unknown signal name; use -l to see recognized names" << std::endl;