]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ansible.git/commitdiff
update: convert legacy grafana-server groupname early
authorGuillaume Abrioux <gabrioux@redhat.com>
Fri, 12 Mar 2021 08:26:16 +0000 (09:26 +0100)
committerGuillaume Abrioux <gabrioux@redhat.com>
Mon, 15 Mar 2021 14:25:48 +0000 (15:25 +0100)
If the legacy name `grafana-server` is still being used when upgrading
from Nautilus to Pacific, the task that sets the fact `rolling_update`
to `true` doesn't run on the node(s) included in that group. Indeed the
play where we set this fact (`rolling_update`) only runs on the group
`monitoring_group_name | default('monitoring')`.
As a workaround, we can run earlier the task which converts the
`grafana-server` group name to `monitoring`.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1935554
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
infrastructure-playbooks/rolling_update.yml

index 81434e9a8f3761a257fbe388b46195fc35c1224e..11009c5af8947ec0f455a0511e9f085de7c27bb8 100644 (file)
            invoking the playbook"
       when: ireallymeanit != 'yes'
 
+    - name: import_role ceph-defaults
+      import_role:
+        name: ceph-defaults
+
+    - name: check if a legacy grafana-server group exists
+      import_role:
+        name: ceph-facts
+        tasks_from: convert_grafana_server_group_name.yml
+      when: groups.get((grafana_server_group_name | default('grafana-server')), []) | length > 0
+
 
 - name: gather facts and check the init system