]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
common/pick_address: pass string by reference
authorKefu Chai <kchai@redhat.com>
Sat, 27 Mar 2021 02:03:02 +0000 (10:03 +0800)
committerKefu Chai <kchai@redhat.com>
Sat, 3 Apr 2021 02:06:13 +0000 (10:06 +0800)
to silence warnings from clang-tidy.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/common/pick_address.cc

index ced5abad84ce5006091e823ab069a418847bea78..a4bdd68ae5203e1bcecb742d2d67593e342c4d27 100644 (file)
@@ -163,8 +163,8 @@ struct Observer : public md_config_obs_t {
 
 static void fill_in_one_address(CephContext *cct,
                                const struct ifaddrs *ifa,
-                               const string networks,
-                               const string interfaces,
+                               const string &networks,
+                               const string &interfaces,
                                const char *conf_var,
                                int numa_node = -1)
 {
@@ -253,8 +253,8 @@ static int fill_in_one_address(
   CephContext *cct,
   const struct ifaddrs *ifa,
   unsigned ipv,
-  const string networks,
-  const string interfaces,
+  const string &networks,
+  const string &interfaces,
   entity_addrvec_t *addrs,
   int numa_node = -1)
 {