]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
crimson/net/Socket: do not reset FixedCPUServerSocket::shutdown_gate
authorKefu Chai <kchai@redhat.com>
Thu, 13 May 2021 16:02:47 +0000 (00:02 +0800)
committerKefu Chai <kchai@redhat.com>
Thu, 13 May 2021 16:08:13 +0000 (00:08 +0800)
the copy constructor of seastar::gate is deleted explicitly. so we
cannot reset FixedCPUServerSocket::shutdown_gate by assigning a new
seastar::gate to it.

since we don't reuse a FixedCPUServerSocket after calling
FixedCPUServerSocket::destroy(), it's safe to leave a closed gate after
calling FixedCPUServerSocket::reset()

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/crimson/net/Socket.h

index d39a2517f959e6c3064d707d1aed649fc11b3613..9cb3006ea5572c016a1be40bbab8e42178dc274c 100644 (file)
@@ -179,7 +179,6 @@ class FixedCPUServerSocket
   seastar::future<> reset() {
     return container().invoke_on_all([] (auto& ss) {
       assert(ss.shutdown_gate.is_closed());
-      ss.shutdown_gate = seastar::gate();
       ss.addr = entity_addr_t();
       ss.listener.reset();
     });