]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
crimson/.../rbm_device: remove unnecessary zero fill in anonymous mmap
authorChanyoung Park <chaney.p@kakaoenterprise.com>
Fri, 15 Aug 2025 18:06:18 +0000 (18:06 +0000)
committerChanyoung Park <chaney.p@kakaoenterprise.com>
Fri, 15 Aug 2025 18:06:18 +0000 (18:06 +0000)
Anonymous mmap is zero-filled on first access by the kernel, so an
explicit memset(0) is redundant and has been removed.

Signed-off-by: Chanyoung Park <chaney.p@kakaoenterprise.com>
src/crimson/os/seastore/random_block_manager/rbm_device.cc

index bc592d12bcbad76ae444fdc8512f8b67926691ec..7cbd6ced39d169ffecb791900703040ca85283bb 100644 (file)
@@ -206,16 +206,12 @@ open_ertr::future<> EphemeralRBMDevice::open(
     "Initializing test memory device {}",
     size);
 
-  void* addr = ::mmap(
-    nullptr,
-    size,
-    PROT_READ | PROT_WRITE, MAP_SHARED | MAP_ANONYMOUS,
-    -1,
-    0);
+  // memset 0 is not needed: anonymous mapping is zero-filled
+  void* addr = ::mmap(nullptr, size, PROT_READ | PROT_WRITE,
+    MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
 
   buf = (char*)addr;
 
-  ::memset(buf, 0, size);
   return open_ertr::now();
 }