drm/bridge: anx7625: Check GPIO description to avoid crash

As GPIO probe function "devm_gpiod_get_optional()" may return error
code, driver should identify GPIO desc as NULL to avoid crash.

Acked-by: Tzung-Bi Shih <tzungbi@google.com>
Signed-off-by: Xin Ji <xji@analogixsemi.com>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20211119015804.3824027-1-xji@analogixsemi.com
Reviewed-by: Robert Foss <robert.foss@linaro.org>

diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 2346dbcc505f20c889bb9af0614ec9b6fbcc8721..9765ac07f46da9ea734c78a19636a983ad518ebd 100644 (file)
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1098,9 +1098,18 @@ static void anx7625_init_gpio(struct anx7625_data *platform)
        /* Gpio for chip power enable */
        platform->pdata.gpio_p_on =
                devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
+       if (IS_ERR_OR_NULL(platform->pdata.gpio_p_on)) {
+               DRM_DEV_DEBUG_DRIVER(dev, "no enable gpio found\n");
+               platform->pdata.gpio_p_on = NULL;
+       }
+
        /* Gpio for chip reset */
        platform->pdata.gpio_reset =
                devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
+       if (IS_ERR_OR_NULL(platform->pdata.gpio_reset)) {
+               DRM_DEV_DEBUG_DRIVER(dev, "no reset gpio found\n");
+               platform->pdata.gpio_reset = NULL;
+       }
 
        if (platform->pdata.gpio_p_on && platform->pdata.gpio_reset) {
                platform->pdata.low_power_mode = 1;