test/osd/RadosModel: WriteOp check retval and is_complete

This change could allow us to have a better understanding on why read got a wrong version.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

diff --git a/src/test/osd/RadosModel.h b/src/test/osd/RadosModel.h
index 15b7ea8b53d6263e9652dbd05b539c9bef733d67..31c4bf20b7e448daf035b20bd95e01afb3b957b4 100644 (file)
--- a/src/test/osd/RadosModel.h
+++ b/src/test/osd/RadosModel.h
@@ -1059,12 +1059,16 @@ public:
       }
 
       context->update_object_version(oid, version);
+      ceph_assert(rcompletion->is_complete());
+      int r = rcompletion->get_return_value();
+      assertf(r >= 0, "r = %d", r);
       if (rcompletion->get_version64() != version) {
        std::cerr << "Error: racing read on " << oid << " returned version "
                  << rcompletion->get_version64() << " rather than version "
                  << version << std::endl;
        ceph_abort_msg("racing read got wrong version");
       }
+      rcompletion->release();
 
       {
        ObjectDesc old_value;
@@ -1076,7 +1080,6 @@ public:
                    << old_value.most_recent() << std::endl;
       }
 
-      rcompletion->release();
       context->oid_in_use.erase(oid);
       context->oid_not_in_use.insert(oid);
       context->kick();