]> git.apps.os.sepia.ceph.com Git - xfsprogs-dev.git/commitdiff
xfs: move the xfs_attr_sf_lookup tracepoint
authorChristoph Hellwig <hch@lst.de>
Mon, 15 Apr 2024 23:07:42 +0000 (16:07 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Wed, 17 Apr 2024 21:06:26 +0000 (14:06 -0700)
Source kernel commit: 14f2e4ab5d0310c2bb231941d9884fa5bae47fab

trace_xfs_attr_sf_lookup is currently only called by
xfs_attr_shortform_lookup, which despit it's name is a simple helper for
xfs_attr_shortform_addname, which has it's own tracing.  Move the
callsite to xfs_attr_shortform_getvalue, which is the closest thing to
a high level lookup we have for the Linux xattr API.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
Reviewed-by: Bill O'Donnell <bodonnel@redhat.com>
libxfs/xfs_attr_leaf.c

index a21740a87aeade209c96734bf2548281feca2615..10ed518f30ee58c79090e5624de904f940d49a46 100644 (file)
@@ -873,8 +873,6 @@ xfs_attr_shortform_lookup(
        struct xfs_attr_sf_entry        *sfe;
        int                             i;
 
-       trace_xfs_attr_sf_lookup(args);
-
        ASSERT(ifp->if_format == XFS_DINODE_FMT_LOCAL);
        sfe = &sf->list[0];
        for (i = 0; i < sf->hdr.count;
@@ -902,6 +900,9 @@ xfs_attr_shortform_getvalue(
        int                             i;
 
        ASSERT(args->dp->i_af.if_format == XFS_DINODE_FMT_LOCAL);
+
+       trace_xfs_attr_sf_lookup(args);
+
        sfe = &sf->list[0];
        for (i = 0; i < sf->hdr.count;
                                sfe = xfs_attr_sf_nextentry(sfe), i++) {